Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sqlite feature flag and document own store implementation #284

Closed
mFragaBA opened this issue Apr 24, 2024 · 3 comments
Closed

Add sqlite feature flag and document own store implementation #284

mFragaBA opened this issue Apr 24, 2024 · 3 comments
Milestone

Comments

@mFragaBA
Copy link
Contributor

mFragaBA commented Apr 24, 2024

I think currently rusqlite comes in both the CLI and the library. We use it to run integration tests for example. It's sort of our "default" store implementation. That's why I find it reasonable to put it under a sqlite feature flag. Perhaps it's better to make an issue to address this in the documentation as well as putting the sqlite store under a feature flag. What do you think?

Originally posted by @mFragaBA in #262 (comment)

@bobbinth
Copy link
Contributor

As a part of this, we may want to break out dependencies which are needed for the CLI binary and then turn on relevant features for a specific use case.

@bobbinth
Copy link
Contributor

This should be closed once #367 is merged.

@igamigo
Copy link
Collaborator

igamigo commented Jun 17, 2024

Closed by #367

@igamigo igamigo closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants