Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: store the accountID as bytes or as two separate u64 to improve indexing #647

Open
tomyrd opened this issue Dec 26, 2024 · 1 comment

Comments

@tomyrd
Copy link
Collaborator

tomyrd commented Dec 26, 2024

Similar to what is stated in 0xPolygonMiden/miden-node#602. We currently store it as a string which may hinder indexing and serialization/deserialization.

The ID prefix can be used as the only primary key as it is a unique identifier, and the sufix is just stored to get the full ID when needed.

@bobbinth
Copy link
Contributor

My intuition is that here performance is much less critical than in the node, so storing account ID as a blob (or even as a string) may be much more acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants