Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"value" argument frame_joint_channel() etc. not working #3

Open
OlafHaag opened this issue Aug 12, 2018 · 1 comment
Open

"value" argument frame_joint_channel() etc. not working #3

OlafHaag opened this issue Aug 12, 2018 · 1 comment

Comments

@OlafHaag
Copy link

Thanks a lot for the script, it's great! But I stumbled across an issue:
The Bvh class member functions frame_joint_channel , frame_joint_channels and frames_joint_channels are all accepting a value argument, yet this argument can't do anything.
In line 148, 157, and 174 there's a check if channel_index == -1 and value is not None:, but channel_index can never be -1, because it's retrieved by self.joint_channels(joint).index(channel) which just throws a ValueError if it can't find channel (e.g. 'Zposition' is not in list), because index() is a simple list member function.

I guess that value was supposed to be a fallback value if the channel wasn't found and the idea was to do a similar check as in joint_parent_index, but was forgotten?

@OlafHaag
Copy link
Author

Hey there! It seems this issue is fixed. Could you please bump the version and push it to https://pypi.org/project/bvh/? Thanks a lot! I really appreciate your work, it helped me to build upon it (https://github.com/OlafHaag/bvh-tools) and add features like writing back to BVH and other formats. That's why I need an updated version of your bvh module on PYPI as a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant