-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make it easier to see output scene #2
Comments
ticket for @Algorush but I can't seem to assign this |
@kfarr hi, what if I create simple flask server with form.html to send user queries to text-to-street.py, that will opened new tab with 3dstreet scene? Is this ok for first version? |
But I also created index-bot.html for option 1 |
here is the ideal case for demo purposes:
I could use help with #3 You mentioned that you already made an index.html that can copy / paste? Maybe we can use that, and the python command-line script generates a url with the generated JSON passed directly in the URL as URL encoded data such as localhost:7001/index-bot/#streetmix-json:[URI ENCODED STREETMIX JSON HERE] |
Yes, I slightly changed the code of the streetmix-loader component so that I could generate a scene from the ready-made json with streetmix format |
@Algorush great could you share that or use it do to the above idea of passing the json directly as URI data? |
Yes, now I’m doing just this to transmit json as URI data. |
Yes that makes sense. Can you check out the streaming demo version? It’s
here
https://github.com/3DStreet/text-to-street/blob/e4303d2af5edc90fb2a2fc31ce2ff0e687e4bc43/functions/texttostreetdemo.py#L53
I couldn’t get functions working with streaming so instead it parses the
streamed output to look for a json snippet
…On Mon, Sep 25, 2023 at 11:35 AM Alexander Goryushkin < ***@***.***> wrote:
Yes, now I’m doing just this to transmit json as URI data.
I just made a version yesterday with a simple flask server that returns
generated json upon request. But it still needs to be checked first,
validated before using it to generate a street. Because GPT sometimes
returns invalid data in json (for example, the type of buildings that is
not in the enum array).
I came up with this option - if the generated segment type or variant is
not in the json schema, then use the default value from the schema
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADS3TLNGU25MDYTNCF4KITX4HFGLANCNFSM6AAAAAA46ZNKM4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I found this (how to run function_call with streaming): https://community.openai.com/t/functions-calling-with-streaming/305742 |
Judging by what I read about function_call, it is still better to use them when generating JSON, with them the structure of the model response is more accurate (in accordance with schema) |
Yeah that solution you posted looks great
…On Mon, Sep 25, 2023 at 1:56 PM Alexander Goryushkin < ***@***.***> wrote:
Judging by what I read about function_call, it is still better to use them
when generating JSON, with them the structure of the model response is more
accurate (in accordance with schema)
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADS3TNSKXPBFR22WC7AKKDX4HVX5ANCNFSM6AAAAAA46ZNKM4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I'll try the streaming option later, okay? Now I have finally achieved that the street opens in a new tab upon request from the flask form |
congrats! do you mind checking in and sharing the current state? I could also use the index-bot.html file you mentioned |
Yes, I had created PR with it: #3 |
the server can also accept a user request and send streetmix json. That is, we can also use streetmix-loader (adding some code) to sending a user query as an attribute. This can be helpful for future UI interface for queries |
As a user making a text-to-street request via the python console running get_streetmix_json function inside texttostreet.py, when a response is provided I should be able to see the scene output after a few seconds.
ideas:
The text was updated successfully, but these errors were encountered: