Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We are not inclusive enough in the heartbeats #15

Open
johan-bjareholt opened this issue Jul 10, 2019 · 2 comments
Open

We are not inclusive enough in the heartbeats #15

johan-bjareholt opened this issue Jul 10, 2019 · 2 comments

Comments

@johan-bjareholt
Copy link
Member

Currently we only send heartbeats when we move the cursor, when we enter a buffer and when we start vim. The heartbeats are only on intervals of 10s. This has the flaw of for example if we are writing a command for a while such as a complex search/replace time will not be counted for that period as it takes more than 10s.

From looking at my own logs I can clearly see that at the editor activity is way too low, adding all my window titles with something VIM related is almost half of what my editor activity is so the activity time is currently not accurate at all while the window activity in my experience is very accurate.

We should start with increasing the pulsetime on the heartbeats as well as investigate if there are more autocmd we can call heartbeats on to make things more accurate.

I started reflecting on this after reading ActivityWatch/aw-watcher-vscode#10

@ErikBjare
Copy link
Member

ErikBjare commented Jul 10, 2019

The pulsetime should probably be ~3 minutes (as it is for the AFK watcher). WakaTime and RescueTime use times of ~15min, and while I think that's a bit extreme I think 3min might be a good value.

If it's changed to 3min, I don't think we need additional hooks to trigger heartbeats.

@johan-bjareholt
Copy link
Member Author

@ErikBjare 3 minutes might be good, but that makes our data more lossy and that can be both a good or bad thing depending on how we want to define "editor activity time" as

See my comment here ActivityWatch/aw-watcher-vscode#10 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants