Skip to content
This repository has been archived by the owner on Apr 5, 2023. It is now read-only.

not all templates are pre-compiled in minified build #23

Open
1 of 2 tasks
stefanpenner opened this issue Mar 20, 2014 · 2 comments
Open
1 of 2 tasks

not all templates are pre-compiled in minified build #23

stefanpenner opened this issue Mar 20, 2014 · 2 comments

Comments

@stefanpenner
Copy link
Contributor

steps to reproduce:

  1. grunt
  2. search dist/ember-widgets.min.js for Ember.Handlebars.compile(

expectation:

in the minified build all templates to be precompiled, so that only the handlebars runtime is required for production builds.

@stefanpenner
Copy link
Contributor Author

for pre compilation of templates, ember itself does the following:

https://github.com/emberjs/ember.js/blob/2556dcf5e764c4c3c98a1f8eaa19e60766473697/packages_es6/ember-handlebars/lib/controls/select.js#L339

and then at build time, we do the precompilation + inline the template.

@blimmer
Copy link
Contributor

blimmer commented Aug 14, 2014

I'd love to see this working. Now that ember-i18n doesn't require the full version of handlebars (as of 2.1.0), I would like to switch over to the runtime. Alternatively, if #68 were fixed, this would also resolve my problem as I'm not using AccordianWidget.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants