Skip to content
This repository has been archived by the owner on Apr 5, 2023. It is now read-only.

Disable doesn't work for select or multi-select #94

Open
artburkart opened this issue Aug 19, 2014 · 4 comments
Open

Disable doesn't work for select or multi-select #94

artburkart opened this issue Aug 19, 2014 · 4 comments
Labels

Comments

@artburkart
Copy link

I've posted a question about this on stackoverflow. I don't really understand why the disabled property doesn't work in the multi-select-component, since it seems to inherit from the select-component where it does work. Cheers.
http://stackoverflow.com/questions/25375319/how-to-disable-multi-select-component-in-ember-widgets

@azirbel azirbel changed the title How do you disable a multi-select-component? Disable doesn't work for multi-select-component Aug 20, 2014
@azirbel azirbel added the bug label Aug 20, 2014
@azirbel
Copy link
Contributor

azirbel commented Aug 20, 2014

Looks like a bug to me; I've edited your title here and tagged it as a bug. A workaround like the one you posted might be your best bet if you want a quick-fix. If you're able to fix the source of the problem in ember-widgets, we'll definitely get it merged in.

Also thanks for providing a JS Bin in your stack overflow question! For reference: http://jsbin.com/subekubi/5/edit.

In the future, if you tag SO questions with "ember-widgets", I'll be more likely to notice them.

@artburkart
Copy link
Author

Yeah, sorry about that. I tried tagging it with "ember-widgets," but SO said I needed a reputation of 1500 to make new tags. 😕
I'm not all too familiar with coffeescript, but I might take a stab at it.

@artburkart
Copy link
Author

@azirbel - So I'm having a little difficulty getting started on this bug. I downloaded and installed ember-widgets, but when I tried editing the select-component in select.hbs, it didn't exhibit the same behavior as my JS bin. Instead, it stops rendering anything that is visible, however, I'm still able to tab over to it because it's in the DOM. Would the code at http://rawgit.com/Addepar/ember-widgets/v0.1.0/dist/js/ember-widgets.js be different from what I've downloaded from the master branch?

@azirbel
Copy link
Contributor

azirbel commented Aug 21, 2014

Oh, I didn't realize ember-widgets wasn't a tag yet. That's too bad.

I just checked what you said, and sure enough - both on master and at v0.1.0, adding disabled=true to the select widget just makes it disappear completely, and doesn't do anything to multi-select. I don't know why it's different in the JS Bin, but fixing it in the demo app is probably the best way to start. Sounds like it's even more buggy than we thought, sorry about that.

@azirbel azirbel changed the title Disable doesn't work for multi-select-component Disable doesn't work for select or multi-select Aug 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

2 participants