Addresses issues 147-166 #168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"...or hedges..."
Added classes: - Windbreak - timberbelt - buffer planting
celineaubert
reviewed
Jan 4, 2022
changed creator ID added a subclass of
celineaubert
reviewed
Jan 4, 2022
celineaubert
reviewed
Jan 4, 2022
not linked to any opened issue. I just saw the term when looking for another one and thought f adding it to AgrO.
celineaubert
reviewed
Jan 5, 2022
| AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "https://en.wikipedia.org/w/index.php?title=Hedge&oldid=1062906324") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/AGRO_00010161> "Tree plantings which are grown in hedgerows but have been allowed to reach their full height and width."@en) | ||
| AnnotationAssertion(<http://purl.org/dc/elements/1.1/creator> <http://purl.obolibrary.org/obo/AGRO_00010161> <https://orcid.org/0000-0003-3985-4911>) | ||
| AnnotationAssertion(<http://purl.org/dc/elements/1.1/date> <http://purl.obolibrary.org/obo/AGRO_00010161> "2022-01-04T00:23:05Z"^^xsd:dateTime) | ||
| AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#hasRelatedSynonym> <http://purl.obolibrary.org/obo/AGRO_00010161> "production hedges") |
There was a problem hiding this comment.
I have asked Peter the definition of this term that does not appear in the source he mentionned neither on any other document.
as the def for this terms include animal shelter and grazing. In agrisilviculture, no animal are included.
reviewed the def of the term based on the source provided by Peter. Also added a new term based on the orginal term mentionned by Peter
reviewed the definition and label
celineaubert
reviewed
Jan 5, 2022
celineaubert
reviewed
Jan 5, 2022
reviewed the definition based on FAO definition
reviewed def and added a source
added broad syn
changed the label: does not seem that ''agroforestry fallow'' term exist. There is only mentions of improved fallow in litterature. Also, I delete the link the shifting cultivation. In shifting cultivation, the fallow phase is not managed at all (and might not include any trees) whereas in the improved fallow it is.
|
Hi Krishna, I've shared my comments either by adding comments on the commit or by direclty modifying the terms in Protege. Hope this is not too messy. |
KrishnaTO
added a commit
to KrishnaTO/agro
that referenced
this pull request
Mar 25, 2022
KrishnaTO
added a commit
to KrishnaTO/agro
that referenced
this pull request
Mar 25, 2022
per comments in PR AgriculturalSemantics#168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits
closes #147
closes #148
closes #149
closes #152
closes #153
closes #155
closes #156
closes #158
closes #160
closes #161
closes #162
closes #164
closes #165
closes #166