From d16e7ddbea4c93ff05760b54fd3968d6d9cc364d Mon Sep 17 00:00:00 2001 From: Charles Tapley Hoyt Date: Tue, 4 Jan 2022 13:36:18 +0100 Subject: [PATCH] Improve tests Un-hardcoding these numbers makes it possible to arbitrarily extend the metric set definitions without needing to change the test code --- tests/integration/test_aggregation.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/integration/test_aggregation.py b/tests/integration/test_aggregation.py index a3e91ff..3df68e6 100644 --- a/tests/integration/test_aggregation.py +++ b/tests/integration/test_aggregation.py @@ -15,13 +15,13 @@ def test_classification(self): score_card = ScoreCard(metric_set) performance_metrics = score_card.generate_report(self.scores) - assert performance_metrics.shape == (1, 11) + assert performance_metrics.shape == (1, len(metric_set)) performance_metrics = score_card.generate_report(self.scores, grouping=["source_group"]) - assert performance_metrics.shape == (5, 11) + assert performance_metrics.shape == (5, len(metric_set)) performance_metrics = score_card.generate_report(self.scores, grouping=["source_group", "target_group"]) - assert performance_metrics.shape == (20, 11) + assert performance_metrics.shape == (20, len(metric_set)) def test_regression(self): metric_set = RatingMetricSet() @@ -29,23 +29,23 @@ def test_regression(self): score_card = ScoreCard(metric_set) performance_metrics = score_card.generate_report(self.scores) - assert performance_metrics.shape == (1, 7) + assert performance_metrics.shape == (1, len(metric_set)) performance_metrics = score_card.generate_report(self.scores, grouping=["source_group"]) - assert performance_metrics.shape == (5, 7) + assert performance_metrics.shape == (5, len(metric_set)) performance_metrics = score_card.generate_report(self.scores, grouping=["source_group", "target_group"]) - assert performance_metrics.shape == (20, 7) + assert performance_metrics.shape == (20, len(metric_set)) def test_addition(self): metric_set = RatingMetricSet() + ClassificationMetricSet() score_card = ScoreCard(metric_set) performance_metrics = score_card.generate_report(self.scores) - assert performance_metrics.shape == (1, 18) + assert performance_metrics.shape == (1, len(metric_set)) performance_metrics = score_card.generate_report(self.scores, grouping=["source_group"]) - assert performance_metrics.shape == (5, 18) + assert performance_metrics.shape == (5, len(metric_set)) performance_metrics = score_card.generate_report(self.scores, grouping=["source_group", "target_group"]) - assert performance_metrics.shape == (20, 18) + assert performance_metrics.shape == (20, len(metric_set))