Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing definitions in examples #33

Open
jacyimp opened this issue Jan 15, 2023 · 0 comments
Open

Missing definitions in examples #33

jacyimp opened this issue Jan 15, 2023 · 0 comments

Comments

@jacyimp
Copy link
Contributor

jacyimp commented Jan 15, 2023

Hey!

Any reason why there are missing definitions in examples?

For instance, example#0 has name, animal, breed, stats, traits; All are missing from php definitions except for name and age.

Is this intended? I can try fixing them if it's not intended. Thought it'd be better to ask first.

For my own implementation, I struggled a bit with how to implement <trait order="2">Friendly</trait>

such as:

<?xml version="1.0"?>
<pet>
    <name>Bear</name>
    <animal>Dog</animal>
    <breed>Australian Labradoodle</breed>
    <stats age="4.0" />
    <traits>
        <trait order="2">Friendly</trait>
        <trait order="2">Bonkers</trait>
    </traits>
</pet>

edit: by using two properties #[Str('/trait/@order')] for "2", and #[Str('/trait')] for "Friendly"

We could add such a case to one of the examples too.

I found out that there's a possibility for nullability to with required later when diving into the code. This could also be an included in the examples.

Let me know how to proceed. And thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant