Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 5 #45

Closed
2 tasks done
jakobnissen opened this issue May 9, 2021 · 3 comments
Closed
2 tasks done

Version 5 #45

jakobnissen opened this issue May 9, 2021 · 3 comments

Comments

@jakobnissen
Copy link
Member

Right, so we've made two breaking changes over the last months:

I'd like to merge v5 soon, since it's required for BioSequences v3. Is anything missing that this package needs?

It would be neat to have an interface (#42), such that it was unabiguously clear what you needed to implement if you wanted to make a new BioSymbol type - but I don't think it's critical to get that into place, and changing the interface could risk being quite breaking, so I think we don't need to do it now, or perhaps ever.

@TransGirlCodes
Copy link
Member

@jakobnissen Ok, I'm going to cut a v5 release now. Holler if that's not good with you?

@jakobnissen
Copy link
Member Author

Fine for me!

@jakobnissen
Copy link
Member Author

Closing this issue as resolved, since v5 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants