Fix wrong use of sizeof() on char* #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'll give it a test and merge in later this week when I have some free time. |
|
Tested ImgDir with a long name and IMG0..9 on my BlueSCSI worked! Thanks for the PR! (I'm going to cherry pick it in momentarily as I forgot to push up the flip back to dev last release). Thanks again! |
|
Cherry picked to main 5087e94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit dd12606, the handling of files assigned to SCSI IDs with the IMG0...IMG9 key is broken if the file name is longer than 3 characters.
DIR0...DIR9 is broken in a similar fashion.
Using RAW sections of the SD card is broken as well if specified in the .ini file.
This PR passes the buffer length in getImg() and getDir() so that the file and directory names do not get truncated at the size of a char pointer.