Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global string dedup cache #123

Open
Bnaya opened this issue Jun 29, 2020 · 0 comments
Open

Global string dedup cache #123

Bnaya opened this issue Jun 29, 2020 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@Bnaya
Copy link
Owner

Bnaya commented Jun 29, 2020

Strings have reference counting, and we save duplicate strings once for every save operation.
It's easy for us, because we create cache at the beginning of the save operation.

But can we do that across different save operations?
If we keep that cache aways alive, it might get stale, leak memory, and won't be useful for other threads.

So the "ultimate" and complex solution would be global string registry inside the objectbuffer memory
(To hold all strings in additional data struct that we can locate them easily)

@Bnaya Bnaya added the help wanted Extra attention is needed label Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant