Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Text is dark in the dark mode #144

Closed
underthestars-zhy opened this issue Mar 21, 2022 · 4 comments · Fixed by #201
Closed

🐞 Text is dark in the dark mode #144

underthestars-zhy opened this issue Mar 21, 2022 · 4 comments · Fixed by #201
Assignees
@MarcoCarnevali
Labels
bug Something isn't working

Comments

@underthestars-zhy
Copy link

I just open a random file

CleanShot 2022-03-21 at 18 39 43@2x

  • OS: 12.3
  • Xcode: 13.3
@underthestars-zhy underthestars-zhy added the bug Something isn't working label Mar 21, 2022
@lukepistrol
Copy link
Member

This is actively being worked on in a overhaul of the Editor #36

@austincondiff
Copy link
Collaborator

I thought this was resolved by #147. It is for the most part, but the font is not applied at all while syntax highlighting is loading. It should at least have the font family applied and in dark mode it should be white while processing.

Then there are files like this that never load and stay like this...

image

@MarcoCarnevali could you look into this?

@austincondiff
Copy link
Collaborator

@underthestars-zhy I've got to ask, what is that emoji sitting on top of the sidebar?

@MarcoCarnevali MarcoCarnevali self-assigned this Mar 23, 2022
@MarcoCarnevali MarcoCarnevali mentioned this issue Mar 23, 2022
Merged
4 tasks
@MarcoCarnevali MarcoCarnevali linked a pull request Mar 23, 2022 that will close this issue
fix: code editor highlight load #201
Merged
4 tasks
@underthestars-zhy
Copy link
Author

@underthestars-zhy I've got to ask, what is that emoji sitting on top of the sidebar?

That is an app. Grammarly

@austincondiff austincondiff changed the title [BUG] - Text is dark in the dark mode 🐞 Text is dark in the dark mode Mar 31, 2022
@austincondiff austincondiff moved this from 🆕 New to 🏁 Complete in CodeEdit Project Feb 14, 2023
xinix909 pushed a commit to xinix909/CodeTransfer that referenced this issue Sep 7, 2024
@RenanGreca
Make STTextView first responder when opening an empty file (CodeEdit C…
248b58f 
…odeEditApp#696) (CodeEditApp#144)

# Description

<!--- REQUIRED: Describe what changed in detail -->

* In `STTextViewController.swift`, the `setCursorPosition` function was
changed so that, if the currently open file is empty, the cursor is
automatically set to the first position and active. This behavior is
similar to other text editors e.g. VSCode.

A related PR is opened in CodeEdit, which works in tandem with this one,
so that newly-created files automatically open in a new editor tab.

# Related Issue

<!--- REQUIRED: Tag all related issues (e.g. * CodeEditApp#23) -->
* [CodeEditApp#696](CodeEditApp#696) from
CodeEdit.
* PR [CodeEditApp#1057](CodeEditApp#1057) from
CodeEdit.

# Checklist

<!--- Add things that are not yet implemented above -->
- [x] I read and understood the [contributing
guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md)
as well as the [code of
conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md)
- [x] My changes generate no new warnings
- [x] My code builds and runs on my machine
- [x] I documented my code
- [x] Review requested

# Screenshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcoCarnevali MarcoCarnevali

Labels
bug Something isn't working
Projects
CodeEdit Project
Status: 🏁 Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: code editor highlight load MarcoCarnevali/CodeEdit
4 participants
@austincondiff @lukepistrol @MarcoCarnevali @underthestars-zhy