Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated BYG recipes #7193

Open
VoidLeech opened this issue Dec 4, 2024 · 3 comments · May be fixed by #7320
Open

Outdated BYG recipes #7193

VoidLeech opened this issue Dec 4, 2024 · 3 comments · May be fixed by #7320
Labels
status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix type: bug Issue where something isn't working

Comments

@VoidLeech
Copy link
Contributor

BYG never got updated to 1.20.1 and is instead succeded by BWG. The datagen is currently for the old mod id

Create/src/main/java/com/simibubi/create/foundation/data/recipe/Mods.java

Line 19 in d48a504

BYG("byg"),

Additionally, there's wood types such as Ether that have been removed, and new ones such as Florus that have been added (I haven't even looked into the flowers/any other BYG compat in Create). So besides updating the mod id, the content should also be reviewed.
@IThundxr IThundxr added the status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix label Dec 4, 2024
@IThundxr IThundxr added the type: bug Issue where something isn't working label Dec 17, 2024
@Attack8
Copy link
Contributor

Attack8 commented Jan 4, 2025

I’ll get this

Attack8 added a commit to Attack8/Create that referenced this issue Jan 30, 2025
@Attack8
More Mod Compat 6
199e88c 
 - Update BYG/BWG compat (closes Creators-of-Create#7193)
@Attack8 Attack8 linked a pull request Jan 30, 2025 that will close this issue
Open
@VoidLeech
Copy link
Contributor Author

Note: when 1.21.1 rolls around, this will likely require another pass, at the very least BWG adds a Spirit wood type, and possibly more.

@Attack8
Copy link
Contributor

Attack8 commented Feb 12, 2025

Note: when 1.21.1 rolls around, this will likely require another pass, at the very least BWG adds a Spirit wood type, and possibly more.

I’ll make sure to update it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix type: bug Issue where something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More Mod Compat 6 Attack8/Create
3 participants
@VoidLeech @Attack8 @IThundxr