Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace header image with Image #1245

Closed
thedoublejay opened this issue Jun 13, 2022 · 0 comments · Fixed by #1252
Closed

replace header image with Image #1245

thedoublejay opened this issue Jun 13, 2022 · 0 comments · Fixed by #1252
Assignees
@fullstackninja864
Labels
area/ui-ux kind/feature New feature request priority/important-soon Will be important soon triage/accepted Triage has been accepted

Comments

@thedoublejay
Copy link
Contributor

What would you like to be added:

Related #1237

Replace div https://github.dev/DeFiCh/scan/blob/main/src/components/index/IndexHeader.tsx#L34-L35 with NextJS Image (https://nextjs.org/docs/api-reference/next/image).

Should utilize some properties

  1. Placeholder
  2. Different sizes
  3. Better image types (.webp) with fallback to SVG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fullstackninja864 fullstackninja864

Labels
area/ui-ux kind/feature New feature request priority/important-soon Will be important soon triage/accepted Triage has been accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ui-ux): replaced div with next image tag for header component DeFiCh/defiscan.live
2 participants
@thedoublejay @fullstackninja864