Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pharo and Rowan tonel writers write definitions in different formats #11

Closed
dalehenrich opened this issue Dec 10, 2020 · 2 comments
Closed

Comments

@dalehenrich
Copy link
Member

Rowan can read Pharo tonel format and Pharo can read Rowan tonel format, but there are non-sematic differences in the file formats that leads to spurious code differences when comparing source.

If it becomes a big enough problem, we might be able to patch the Pharo9 tonel writer to conform to the format used by Rowan in order to avoid a lot of diff noise.

In the long run Rowan needs to be able to write using the pharo format (impying that there will be a different tonel format that needs to be supported), but in the short term a relatively simple tonel hack would be more expedient

@martinmcclure
Copy link
Member

RSR patches Pharo to output the symbol->string format. Are there other problems in writing Sparkle code from Pharo?

@dalehenrich
Copy link
Member Author

If this is patched, then we are good to go ... this was a preemptive bug report, because I anticipated problems :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants