Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project dependencies to latest compatible versions #509

Closed
brylie opened this issue Jan 2, 2020 · 6 comments · Fixed by #524
Closed

Update project dependencies to latest compatible versions #509

brylie opened this issue Jan 2, 2020 · 6 comments · Fixed by #524
Milestone

Comments

@brylie
Copy link
Member

brylie commented Jan 2, 2020

There are several security updates available. Update the project dependencies to the latest compatible versions.

@brylie brylie added this to the 1.1 milestone Jan 2, 2020
@shailee-m
Copy link
Member

@brylie After upgrading to meteor 1.9, the vue component throws a build error.
Here is the issue, meteor-vue/vue-meteor#392 where I am expecting a resolution.

For now, I can update the other packages without updating the meteor version or remove the vue component from front-page (if migrating to Vue is not a priority) and update meteor to version 1.9.

@brylie
Copy link
Member Author

brylie commented Mar 11, 2020

Migrating to Vue is not a priority at this time, so the 1.9 upgrade would be more important :-)

I suppose we can deprecate the Meteor Vue stuff if it is not too difficult. Thanks @shailee-m

@shailee-m
Copy link
Member

I think we must hide all tests testing collection hooks untill this issue is resolved: hwillson/meteor-stub-collections#35 . The collection hooks are not getting stubbed so tests related to it are failing.

@brylie
Copy link
Member Author

brylie commented Mar 18, 2020

OK, sounds good. How extensively do we use collection hooks? Might we just deprecate that package?

@shailee-m
Copy link
Member

We mostly use allow-deny while adding/updating activities and residencies as in some client forms we are directly using the collection name to save the records.

@brylie
Copy link
Member Author

brylie commented Mar 20, 2020

OK, it looks like there will soon be a pull request to fix the regression. Let's keep things as-is. Disable the tests, if you feel it would be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants