Holodex+ breaks channel icon and subscribe button

[Robot-Inventor]

When Holodex+ extension is enabled, channel icon and subscribe button in embedded player are broken.

Screenshots

When Holodex+ is disabled

When Holodex+ is enabled

Device

• Firefox Developer Edition v105.0b9
• Windows 11 21H2
• Holodex+ v0.0.4

[sphinxrave]

Ah, thanks for the bug report... it's probably some of the flags we override for the YT Player here https://github.com/HolodexNet/Holodex-Plus/blob/dev/src/content/yt-player-overrides.inject.ts , but will have to investigate a bit more...

[Robot-Inventor]

@sphinxrave Thanks for the reply. I'll share some info what I investigated and found out.

• Holodex+ for Chrome doesn't break the channel icons. The problem only occurs when using Firefox
• Firefox's Enhanced Tracking Protection status has nothing to do with this issue.
• It seems that if the ".ytp-title-enable-channel-logo" class is set to "#movie_player" element in the embedded player, it overrides the "display: none;" of the channel icon and displays it.
  
• The ".ytp-title-enable-channel-logo" class is not set when Holodex+ is enabled in Firefox

If I find out anything new, I'll share it with you again😃

[sphinxrave]

... Actually i can't reproduce it

[Robot-Inventor]

...I have to investigate more. Some browser settings and Holodex+ may be interfering.

[sphinxrave]

Yeah, but maybe don't spend so much time on it considering it's just a minor UI issue that isn't broadly affecting people 👍

It's more important that Holodex+ should add a feature for identifying when 3rd Party Cookies are disabled and YT within iframe doesn't know who the user is, then tell Holodex by window.postMessage to alert the user to fix it.

[Robot-Inventor]

I checked again today and the channel icons were showing up. However, sometimes they don't show up...

screen_record_resized.mp4

But I agree with you that this issue is not a big one and that 3rd party cookie related features are more important.🙂 I had a hard time finding the extension that was causing log in issue, and some people on Twitter were saying they have same one.

Especially baffling with DuckDuckGo Privacy Essentials, adding Holodex and YouTube to the whitelist still causes problems with video playback☹️

[sphinxrave]

It should be possible to detect the third party cookie issue, but i wonder how to word the 'popup'. It's such a technical problem that I have a hard time conveying it simply to an average user. "Hey just change your browser's privacy settings and validate you don't have any extensions that impact 'third party cookies'" is very wordy and complicated 😢

[Robot-Inventor]

Choosing a message to display to a user is always a difficult problem.

I think the simplest message is to specify the name of extension like "Please disable Privacy Badger. It may occur some problems." But can Holodex identify installed extensions?

You may be able to identify the extension by examining the code inserted on the page, but it is technically difficult. 🤔

[sphinxrave]

Doesn't survive updates, also would be the most powerful anti-adblock detection script i've ever seen.

[Robot-Inventor]

Hmm... Well then, how about the message like, "Please disable the extensions on following list", and list major extensions that may cause problems regardless of whether they are installed by the user?