Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not render all columns in md table mode? #26

Open
azazellochg opened this issue Mar 31, 2020 · 1 comment
Open

Do not render all columns in md table mode? #26

azazellochg opened this issue Mar 31, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@azazellochg
Copy link
Member

Transferred from scipion-em/scipion-em-relion#19:

When open set of 2d classes and display particles from a certain class in table mode, the default table looks a bit of overkill, also making it slow to render. There are 60 columns!!!!
screenshot_20190115_163011

I am thinking maybe we should not display the following columns by default, a lot of them are empty of duplicating the other ones:

  • label (empty)
  • comment (empty)
  • coordinate.micId (micid is enough?)
  • ctfmodel.micobj.index
  • ctfmodel.micobj.filename (this causes very slow rendering)
  • ctfmodel.micobj.index
  • ctfmodel.micobj.micname (same as coordinate.micname in most cases)
  • ctfmodel.micobj.plotglobal.index
  • ctfmodel.micobj.plotglobal.samplingrate
  • ctfmodel.micobj.psdjpeg.index
  • ctfmodel.micobj.psdjpeg.filename (this causes very slow rendering, it's same thing
    as ctfmodel.micobj.filename)
  • ctfmodel.micobj.psdjpeg.samplingrate
  • ctfmodel.micobj.thumbnail.index
  • ctfmodel.micobj.thumbnail.filename
  • ctfmodel.micobj.thumbnail.samplingrate

Thoughts? @pconesa

@pconesa
Copy link
Member

pconesa commented Apr 1, 2020

I agree, it seems too much.

Just 2 comments:
1.- Not sure if hiding them will increase performance, but in any case is worth trying and at leass not overwhelm users with all those fields.
2.- This one might be tricky to resolve. Since the particles "view" is triggered from java itself if I'm right with the default behaviour (show everything). The decision, I guess should come from python, and that communication is not established.

We need to think how to provide that control to python code, or come up with a "general/common list of fields to hide/or show.

Thanks, @azazellochg.

@albertmena albertmena added the enhancement New feature or request label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants