Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible control of the invocations of regions of interest to be sampled #5

Open
rbertran opened this issue Jun 17, 2019 · 2 comments

Comments

@rbertran
Copy link
Collaborator

rbertran commented Jun 17, 2019

Selective sampling of invocations can be implemented in both "sides":

  • Tracer: tracer decides if a particular execution of the region of interest needs to be sampled.
    • Pros: Less overhead if we decide to not sample.
    • Cons: Less information. Tracer does not have information about previous sampled regions. As a result, only random or simple (e.g. first 10) sampling methods can be implemented (no intelligent sampling)
  • Tracee: tracee decides if a particular execution of the regions of interest needs to be sampled.
    • Cons: Some overhead if we decide to not sample.
    • Pros: tracee can use existing samples (e.g. historical data) to decide or not to sample a particular region.

I do think that having both would be beneficial. One one side, we can use the Tracer sampling to do a first level pruning of the executions (e.g. from 1 million to 1 thousand) and then use the Tracee extra information available to do a second and more intelligent filtering.

@rbertran
Copy link
Collaborator Author

rbertran commented Aug 9, 2021

With the new infrastructure, this "on-the-fly" tracing approach can be implemented to avoid the full profiling of an entire application.

@rbertran
Copy link
Collaborator Author

rbertran commented Mar 2, 2022

Using the clustering approach, this issue less important. We profile all invocations using chop-perf-invok and then select specific invocations after clustering. So, it is not a high priority anymore to generate on the fly this intelligent invocation selection.

@rbertran rbertran changed the title Flexbile control of the regions of interest to be sampled Flexible control of the invocations of regions of interest to be sampled Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant