Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a PA, liaison or admin I want to be able to see all past reservations. #482

Open
nopivnick opened this issue Nov 7, 2024 · 8 comments

Comments

@nopivnick
Copy link
Collaborator

No description provided.

@nopivnick nopivnick added this to the 2025 Spring milestone Nov 7, 2024
nimanns added a commit that referenced this issue Nov 17, 2024
- General code cleanup.
- Implement a function to fetch all bookings with pagination if the user is an admin, pa or liason.
- Fix an issue with page permission where it wasn't changing after the user email and admins array were loaded.
nimanns added a commit that referenced this issue Dec 3, 2024
Progress on issue #482 show previous bookings for admin, PA and Liason:
@nopivnick
Copy link
Collaborator Author

nopivnick commented Dec 3, 2024

@nimanns

let's use one table for future and past bookings and use the drop down in the upper right of the bookings table to select different time periods:

  • Today
  • This Week
  • All Future
  • Past 24 hours
  • Past Week
  • Past Month
  • Past 6 Months
  • All Past

Image

@nopivnick
Copy link
Collaborator Author

@nimanns we also need to provide Liaisons with a dropdown menu so they can see/select past bookings. @lucia-gomez might want to weigh-in given Liaisons haven't had that feature before.

@nopivnick
Copy link
Collaborator Author

@nimanns just making sure this is on your radar.

@nimanns
Copy link
Collaborator

nimanns commented Dec 13, 2024

@nopivnick I'm on it

@nopivnick
Copy link
Collaborator Author

@nimanns

this is looking better, thanks.

can we lose the "Load More" paging and simply load as many bookings as captured by the period of time selected in the drop down?

Image

@nimanns
Copy link
Collaborator

nimanns commented Dec 20, 2024

@nopivnick

Are you sure? As the number of bookings increases, this will significantly impact loading times, especially for the 'All Past' option. Any growing table like this would benefit from pagination.

@nopivnick
Copy link
Collaborator Author

@nimanns

okay, let's get rid of "All Past", make it "Past 9 Months", and lose the pagination.

if they need to look up anything older than 9 months they can do a data dump of the db.

sound fair?

@nimanns
Copy link
Collaborator

nimanns commented Dec 22, 2024

@nopivnick

Sounds good, will create a PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants