-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a PA, liaison or admin I want to be able to see all past reservations. #482
Comments
- General code cleanup. - Implement a function to fetch all bookings with pagination if the user is an admin, pa or liason. - Fix an issue with page permission where it wasn't changing after the user email and admins array were loaded.
Progress on issue #482 show previous bookings for admin, PA and Liason:
let's use one table for future and past bookings and use the drop down in the upper right of the bookings table to select different time periods:
|
@nimanns we also need to provide Liaisons with a dropdown menu so they can see/select past bookings. @lucia-gomez might want to weigh-in given Liaisons haven't had that feature before. |
@nimanns just making sure this is on your radar. |
@nopivnick I'm on it |
this is looking better, thanks. can we lose the "Load More" paging and simply load as many bookings as captured by the period of time selected in the drop down? |
Are you sure? As the number of bookings increases, this will significantly impact loading times, especially for the 'All Past' option. Any growing table like this would benefit from pagination. |
okay, let's get rid of "All Past", make it "Past 9 Months", and lose the pagination. if they need to look up anything older than 9 months they can do a data dump of the db. sound fair? |
Sounds good, will create a PR for that. |
No description provided.
The text was updated successfully, but these errors were encountered: