Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROD] Remove 'Get Started' from all wallet states #4213

Open
melyndav opened this issue Jan 30, 2025 · 2 comments · May be fixed by #2448
Open

[PROD] Remove 'Get Started' from all wallet states #4213

melyndav opened this issue Jan 30, 2025 · 2 comments · May be fixed by #2448
Assignees
@rdig
Labels
bug Something isn't working Priority: P3 (Low)

Comments

@melyndav
Copy link

melyndav commented Jan 30, 2025 •
edited
Loading

Steps to reproduce

  1. Navigate to the CDapp.
  2. Select the hamburger icon in the top right-hand corner.
  3. From the dropdown menu, select 'Get Started'.
  4. Note nothing happens since you're already on the CDapp landing page.

Expected behaviour

  • The 'Get started' menu item should be removed from the dropdown menu, in the connected and not connected states across all responsive sizes.

Actual behaviour

  • The 'Get started' menu item triggers from the hamburger menu on the landing page is no longer relevant with the latest landing page iterations.

Disconnected wallet state:
Image

Connected wallet state:

Image
@melyndav melyndav added bug Something isn't working Priority: P3 (Low) labels Jan 30, 2025
@rdig rdig self-assigned this Jan 30, 2025
@rdig rdig linked a pull request Jan 30, 2025 that will close this issue
Open
rdig added a commit that referenced this issue Jan 30, 2025
@rdig
Remove: UserMenu "Get Started" menu entry
35a2397 
Fixes #4213
jakubcolony pushed a commit that referenced this issue Feb 5, 2025
@rdig @jakubcolony
Remove: UserMenu "Get Started" menu entry
d796624 
Fixes #4213
@melyndav
Copy link
Author

melyndav commented Feb 7, 2025

Can we close this issue since it's been deployed to production @rdig @jakubcolony

jakubcolony pushed a commit that referenced this issue Feb 7, 2025
@rdig @jakubcolony
Remove: UserMenu "Get Started" menu entry
6fa2772 
Fixes #4213
@rdig
Copy link
Member

rdig commented Feb 7, 2025

This will be automatically closed by my #2448 which actually fixed this issue, but since that wasn't merged into master yet, this is still open

Once I merge it, it will automatically close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdig rdig

Labels
bug Something isn't working Priority: P3 (Low)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for the Dynamic(xyz) wallet library JoinColony/colonyCDapp
2 participants
@rdig @melyndav