Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to enable using W; as a wash scheme - needed for DiTi evos. #78

Closed
wants to merge 1 commit into from
Closed

Conversation

NikolasvdEichen
Copy link

As discussed in the open issue, this is a change to enable using the right wash scheme for diti evos that strictly require an "W;" as a wash scheme and do not cope with "W1;" or any other number.
Question: Do you bump the version number manually or automatically for the pypi build?

Copy link

github-actions bot commented Jul 15, 2024

Thank you for your submission, we really appreciate it!

Like many open-source projects we ask that you sign our Contributor License Agreement before we can accept your contribution.
To sign, please post two separate comments based on the following templates 👇

  1. Comment:

- [ ] The JuBiotech maintainers know my real name.

At least one of the following two applies:

- [ ] The JuBiotech maintainers know my current employer.

- [ ] I am *not* making this contribution on behalf of my current employer.

  1. Comment:
    I have read the CLA Document and I hereby sign the CLA.
    You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@NikolasvdEichen
Copy link
Author

- [ ] The JuBiotech maintainers know my real name.

I do not know what I am supposed to do tbh - Michael knows my real name and my current employer.

@michaelosthege
Copy link
Member

- [ ] The JuBiotech maintainers know my real name.

I do not know what I am supposed to do tbh - Michael knows my real name and my current employer.

Just copy the code block from the first bot comment, tick the boxes (yes, we know your name, and also your current employer), and post it as a comment.

Then post a second comment with the text "I have read the CLA Document and I hereby sign the CLA." and the bot will re-run and approve.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.41%. Comparing base (79a4410) to head (2331031).
Report is 45 commits behind head on master.

Files with missing lines Patch % Lines
robotools/worklists/base.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   95.37%   95.41%   +0.04%     
==========================================
  Files          18       19       +1     
  Lines        1102     1156      +54     
==========================================
+ Hits         1051     1103      +52     
- Misses         51       53       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NikolasvdEichen
Copy link
Author

NikolasvdEichen commented Jul 17, 2024

- [ ] The JuBiotech maintainers know my real name.

I do not know what I am supposed to do tbh - Michael knows my real name and my current employer.

Just copy the code block from the first bot comment, tick the boxes (yes, we know your name, and also your current employer), and post it as a comment.

Then post a second comment with the text "I have read the CLA Document and I hereby sign the CLA." and the bot will re-run and approve.

Hi,
problem: I can not do any virtual signing of a CLA without including our legal department, which will probably take a few weeks or even months - which is way too long.
Is there any other way to do this without me having to chase lawyers for weeks?

@michaelosthege
Copy link
Member

Sure, I will just make a new PR with the equivalent feature ;)


Independent of that, you're welcome to attempt to get a go from your legal department just in case you're making more contributions in the future.

FZ Jülich's legal department was OK with the bot-assisted, digital workflow, but we can also take handwritten signatures on the CLA document. We can manually commit a PDF to the behind-the-scenes repository where the CLA bot also makes commits to document digital signatures.
We can continue this by email if you like.

@NikolasvdEichen NikolasvdEichen closed this by deleting the head repository Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants