Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aqua connector with http hardcoded in helper #421

Open
mrmonblu opened this issue Aug 5, 2022 · 2 comments
Open

Aqua connector with http hardcoded in helper #421

mrmonblu opened this issue Aug 5, 2022 · 2 comments
Assignees

Comments

@mrmonblu
Copy link

mrmonblu commented Aug 5, 2022

https://github.com/KennaSecurity/toolkit/blob/main/tasks/connectors/aqua/lib/aqua_helper.rb, Lines 10, 36, 56, 76 have http hardcoded for aqua url's.
suggested fix:
add option for https, such as
in aqua.rb:
{ name: "aqua_console_https", type: "boolean", required: false, default: nil, description: "Use HTTPS? true/false" },
And
aqua_url = aqua_console_https ? "https://#{aqua_url}" : "http://#{aqua_url}"

In aqua\lib\aqua_helper.rb:
aqua_auth_api = "#{aqua_url}/api/v1/login"
(same for all relevant lines, removing the protocol from the url)

@annapoltieva
Copy link
Contributor

Thanks for creating the issue, will resolve it.

@mukhansk
Copy link
Contributor

Hi)
Looks like I fixed your issue. Could you check that everything is working properly?
PR link: https://github.com/KennaSecurity/toolkit/pull/432/files

@mukhansk mukhansk self-assigned this Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants