We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/KennaSecurity/toolkit/blob/main/tasks/connectors/aqua/lib/aqua_helper.rb, Lines 10, 36, 56, 76 have http hardcoded for aqua url's. suggested fix: add option for https, such as in aqua.rb: { name: "aqua_console_https", type: "boolean", required: false, default: nil, description: "Use HTTPS? true/false" }, And aqua_url = aqua_console_https ? "https://#{aqua_url}" : "http://#{aqua_url}"
{ name: "aqua_console_https", type: "boolean", required: false, default: nil, description: "Use HTTPS? true/false" },
aqua_url = aqua_console_https ? "https://#{aqua_url}" : "http://#{aqua_url}"
In aqua\lib\aqua_helper.rb: aqua_auth_api = "#{aqua_url}/api/v1/login" (same for all relevant lines, removing the protocol from the url)
aqua_auth_api = "#{aqua_url}/api/v1/login"
The text was updated successfully, but these errors were encountered:
Thanks for creating the issue, will resolve it.
Sorry, something went wrong.
Hi) Looks like I fixed your issue. Could you check that everything is working properly? PR link: https://github.com/KennaSecurity/toolkit/pull/432/files
mukhansk
No branches or pull requests
https://github.com/KennaSecurity/toolkit/blob/main/tasks/connectors/aqua/lib/aqua_helper.rb, Lines 10, 36, 56, 76 have http hardcoded for aqua url's.
suggested fix:
add option for https, such as
in aqua.rb:
{ name: "aqua_console_https", type: "boolean", required: false, default: nil, description: "Use HTTPS? true/false" },
And
aqua_url = aqua_console_https ? "https://#{aqua_url}" : "http://#{aqua_url}"
In aqua\lib\aqua_helper.rb:
aqua_auth_api = "#{aqua_url}/api/v1/login"
(same for all relevant lines, removing the protocol from the url)
The text was updated successfully, but these errors were encountered: