Remove scheme prefix from helpers for graylog.elasticsearch.hosts. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Puskar <[email protected]>
|
@CVirus can you review if |
|
@KongZ LGTM |
|
@jpuskar please remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR fixes a regression introduced by the use of the variable name
GRAYLOG_ELASTICSEARCH_HOSTSintroduced in PR #101.Which issue this PR fixes
Special notes for your reviewer
I wasn't sure whether to try to append the scheme or remove the conditional. However, I chose to align with the values.yaml documentation below, where the scheme is included in the input as opposed to added by the chart. I
think trying to handle it elsewhere will end up doing string replacements, which would get messy.
https://github.com/KongZ/charts/blob/main/charts/graylog/values.yaml#L367
Checklist
@KongZ