Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: there need to be some comment to explain PodOpsLifecycle procedure #27

Open
wu8685 opened this issue Aug 16, 2023 · 0 comments
Open

Enhancement: there need to be some comment to explain PodOpsLifecycle procedure #27

wu8685 opened this issue Aug 16, 2023 · 0 comments
Assignees
@shaofan-hs
Labels
kind/enhancement New feature or request operating

Comments

@wu8685
Copy link
Collaborator

wu8685 commented Aug 16, 2023

What would you like to be added?

add some comment to explain PodOpsLifecycle procedure in webhook codes, like here https://github.com/KusionStack/kafed/blob/main/pkg/webhook/server/generic/pod/opslifecycle/webhook.go#L123

also the codes here could be refactored more readable.

Why is this needed?

Users may be confused while reading these codes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaofan-hs shaofan-hs

Labels
kind/enhancement New feature or request operating
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wu8685 @shaofan-hs