Code Independent Code Points (CICP) in PNG images not supported

[svgeesus]

Summary

Running this WPT https://wpt.live/png/cicp-chunk.html gives a fail in Ladybird.

Operating system

Linux

Steps to reproduce

1. Go to https://wpt.live/png/cicp-chunk.html

Expected behavior

Read "pass"

Other browsers support this, see
https://wpt.fyi/results/png?label=master&product=chrome%5Bexperimental%5D&product=edge%5Bexperimental%5D&product=firefox%5Bexperimental%5D&product=safari%5Bexperimental%5D&product=ladybird

Actual behavior

Read "fail"

URL for a reduced test case

https://wpt.live/png/cicp-chunk.html

HTML/SVG/etc. source for a reduced test case

n/a

Log output and (if possible) backtrace

n/a

Screenshots or screen recordings

No response

Build flags or config settings

No response

Contribute a patch?

• I’ll contribute a patch for this myself.

[svgeesus]

Specification link: https://w3c.github.io/png/#cICP-chunk

CICP is very small (4 bytes) compared to a typical RGB ICC profile (5-20k) so usage is increasing.

[LucasChollet]

Support for ICC profiles in Ladybird is globally pretty shallow, but that should be fairly easy to add. I'll try to submit a patch soon.

[trflynn89]

@LucasChollet I suspect we can close this issue now, or was there more cICP work you wanted to do first?

[LucasChollet]

All cICP tests are passing but we only support the subset that makes the tests pass. That plus I wanted to import png/cicp-chunk.html with the import script and that's currently broken.
I can open new issues for these two items if you prefer.

[trflynn89]

Gotcha, using this same issue is fine, just wanted to check!

[svgeesus]

Web Platform Tests is now showing Ladybird passing