Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages #5

Open
Lysxia opened this issue Jul 8, 2018 · 5 comments
Open

Better error messages #5

Lysxia opened this issue Jul 8, 2018 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Lysxia
Copy link
Owner

Lysxia commented Jul 8, 2018

.

@Lysxia Lysxia added enhancement New feature or request help wanted Extra attention is needed labels Jul 8, 2018
@yairchu
Copy link
Contributor

yairchu commented Jul 4, 2019

As previously discussed, we can create better error message for lack of instances for some types.

I'd like to integrate this into the library, but would like some guidance on where you would like the ErrorIfSum class to go.

Another consideration is how should compile-time error message be tested.

@chshersh
Copy link

chshersh commented Jul 4, 2019

@yairchu Regarding testing of compile-time error messages: you can use doctest for that. See example from relude:

@Lysxia
Copy link
Owner Author

Lysxia commented Jul 4, 2019

Thanks for working on this!

I think it would make sense as a new .Internal.Error module. doctest is also a good idea!

@Lysxia
Copy link
Owner Author

Lysxia commented Jul 4, 2019

And it may also be useful to export a couple of generics-related error combinators from the toplevel Generic.Data so they can be used by external instances for Generically (such as #21 discusses).

@yairchu
Copy link
Contributor

yairchu commented Jul 4, 2019

And it may also be useful to export a couple of generics-related error combinators from the toplevel Generic.Data so they can be used by external instances for Generically (such as #21 discusses).

Good point. After your feedback on the PR we could move on that. I would certainly want these for the external instances!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants