Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise IdSortable by using bitwise operations on a Unit32Array with size 4 #4

Open
CMCDragonkai opened this issue Oct 13, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@CMCDragonkai
Copy link
Member

Is your feature request related to a problem? Please describe.

Currently IdSortable uses bitstrings for construction. This is a bit inefficient. We can use a size 4 Uint32Array and do bitwise operations instead.

Describe the solution you'd like

Have to ensure that we handle the non-aligned bits. Some right shift and left shift should be appropriate.

This shouldn't affect decoding.

@CMCDragonkai CMCDragonkai added the enhancement New feature or request label Oct 13, 2021
@CMCDragonkai
Copy link
Member Author

Benchmarks should be done to ensure that we can actually test how more performance it is.

@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2024
@tegefaulkes
Copy link
Contributor

Linear marked this as stale so I'm reopening.

@tegefaulkes tegefaulkes reopened this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants