-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: MMKV Module could not be found #199
Comments
Hello @felipecamposfabel thanks for reporting. @vishnumad will you look into this issue? Thanks |
You can provide a storage object as a constructor param in const customStorage = {
set: (key, value) => { ... },
getString: (key) => { ... },
delete: (key) => { ... }
};
const provider = new WalletMobileSDKEVMProvider({ storage: customStorage }); @bangtoven, @cb-jake - Any thoughts on just removing the |
It's nice to have a default storage option with the SDK so that we don't have to provide one every time. It would be nice if we didn't need to import mmkv as a dependency in our project and that it would just work by importing the Coinbase SDK. |
@vishnumad Thanks for the fast reply. Providing a custom storage works! |
But calling
EDIT: using |
@felipecamposfabel Are you seeing any errors in console or in Android logcat? await initiateHandshake([
{
method: 'eth_requestAccounts',
params: {}
}
]); |
@vishnumad There's nothing on logcat nor on the console. Tried |
@felipecamposfabel I wasn't able to reproduce the issue using our example app. Would you be able to share an example where I can reproduce the issue? screen-20230307-182515_2.mp4 |
@vishnumad I'll try to provide you with an App. In the meantime, after reinstalling my App on Android the app now crashes every time I call
Also on iOS, on every reload of the app, the app freezes with a |
@felipecamposfabel Thanks for providing that example. I just released version 1.0.5 that should fix the issue you were running into with handshakes. |
@vishnumad Thanks for the update. With version 1.0.5 the Android app connects to Coinbase Wallet. But every time the user cancels any request/transaction, when coinbase redirects to the app, it just crashes on Android. You can try it on the app I sent you. EDIT: The app also crashes on iOS Also, why do I need to persist the connected address myself (since it's undefined every time the app is relaunched)? Shouldn't the |
Describe the bug
The react-native-mmkv native module is not being installed with auto-linking on Bare RN Project
Steps
const cbProvider = new WalletMobileSDKEVMProvider();
I'm running on RN 0.71.3. And I do not use MMKV on my project.
Two side notes.
WalletMobileSDKEVMProvider
is not exported on@coinbase/wallet-mobile-sdk
(need to import it from its file.Thanks!
Expected behavior
The project should run as per docs
Version
1.0.4
Additional info
No response
Desktop
No response
Smartphone
No response
The text was updated successfully, but these errors were encountered: