Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off spatial reordering when aggregating #432

Closed
bekozi opened this issue Nov 14, 2016 · 1 comment
Closed

Turn off spatial reordering when aggregating #432

bekozi opened this issue Nov 14, 2016 · 1 comment
Assignees
@bekozi
Labels
enhancement
Milestone
v1.3.2

Comments

@bekozi
Copy link
Contributor

bekozi commented Nov 14, 2016

Spatial reordering has no effect when aggregating to selection geometries. It should be turned off in the presence of a subset geometry and spatial aggregation. This is a fix for the special case of spatial aggregations and spatial reordering - keeping the bounds for spatial aggregations (#431)!

Ping @tomLandry, @nilshempelmann.
@bekozi bekozi added this to the v1.4.0 milestone Nov 14, 2016
@bekozi bekozi self-assigned this Nov 14, 2016
bekozi added a commit that referenced this issue Nov 14, 2016
@bekozi
ENH: Turn off spatial reordering when aggregating #432
ce274fc 
A warning is raised when spatial_reorder=True and aggregate=True
indicating spatial reordering is not done.
bekozi added a commit that referenced this issue Nov 14, 2016
@bekozi
ENH: Turn off spatial reordering when aggregating #432
85b8919 
Added doc note.
@bekozi
Copy link
Contributor Author

bekozi commented Nov 15, 2016

Update is available in the Anaconda ocgis-next package. If this fixes the aggregate + spatial reordering issue for the time being, I'll close this!

@bekozi bekozi closed this as completed Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bekozi bekozi

Labels
enhancement
Projects
None yet
Milestone
v1.3.2
Development

No branches or pull requests
1 participant
@bekozi