-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FHIR Mapping Cardinalities in NCPI Person #90
Comments
It does look like some of the logical model Person didn't translate well into the IG, and those mapping fields are confusing as described. Let's make edits to the logical model as well, adjusting the |
Regarding how to update the documentation, my mental model looks a little different. It's reasonable to take an approach like this, though. I'd probably think about the predicate more like "Has the study reported individual" or something similar. The NCPI participant resources "grouped" by a person may have "is" relationships, but the Person is of a different type in my book. Maybe that's too confusing. If your team wants to create a PR with your recommended changes, we can get the WG to review. |
comment for discussion in the meeting Reading your response, that didn't seem to communicate what we intended. Here is a new version of how we might update the FHIR Mapping tables. I'd like a summary of how to interpret the FHIR mapping tables inserted in the overview materials (or its own page) and linked from the FHIR Mapping section. The example (minus the explanatory rows) would go into the NCPI Person page. Proposed FHIR mapping explanation sectionHow to interpret the FHIR Mapping SectionThe FHIR mapping table represents the cardinality of the relationship implied by a field or fields as a UML class diagram would describe them and how that maps to the logical model. Each mapped field is represented by a row in a table with the following columns:
Example FHIR Mapping with explanationsThe "brief table" row shows what we'd expect to see in the table. The "Verbose explanation" and "Implication" rows explain the semantics.
|
Description
The FHIR mapping section of the NCPI Person resource currently states:
This can be misread to imply each Person is related to 0..1 Participant resources by the
link.target
field. But we know from:https://nih-ncpi.github.io/ncpi-fhir-ig-2/StructureDefinition-ncpi-person.html
that one Person can link to multiple Participants:
Proposed Clarification
We want to represent the relationship in a clearer subject–predicate–object form, ensuring the cardinalities are more explicit:
Person.target.link
Rationale
Explicitly separating subject and object clarifies the relationship. The current mapping might be interpreted incorrectly, so a more detailed table (with fully qualified locations of mapping fields) would avoid ambiguity. This fix would keep the logical relationship modeling aligned with how multiple Participants might map to a single Person (e.g., in multi-study scenarios).
The text was updated successfully, but these errors were encountered: