Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown() hangs forever when nats-server is listening to signals #14

Closed
Nintron27 opened this issue Jan 9, 2025 · 0 comments · Fixed by #15
Closed

Shutdown() hangs forever when nats-server is listening to signals #14

Nintron27 opened this issue Jan 9, 2025 · 0 comments · Fixed by #15
Labels
bug Something isn't working

Comments

@Nintron27
Copy link
Owner

Nintron27 commented Jan 9, 2025

If Shutdown() is called and nats-server was passed NoSigs false, but the call to Shutdown wasn't induced by a system signal, then Shutdown will hang forever because if it calls nats-server Shutdown() it will cause an internal function to panic due to nats-io/nats-server#6358.

A potential fix in the meantime would be to duplicate the signals nats-server listens for internally and if that context is cancelled then don't call Shutdown().

@Nintron27 Nintron27 added the bug Something isn't working label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant