Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding LaunchAzimuth #54

Open
Patrykz94 opened this issue Nov 2, 2024 · 1 comment
Open

Overriding LaunchAzimuth #54

Patrykz94 opened this issue Nov 2, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@Patrykz94
Copy link
Contributor

I noticed that according to the documentation, the global controls lexicon has an optional key launchAzimuth which is supposed to override the automatic azimuth calculation, however, that key in controls is never used in the code, instead there is a check if launchAzimuth exists on the mission lexicon and if not, it is being calculated and added to mission.

I think it makes more sense to have it on the mission lexicon since I'd imagine this would be used for specific missions, rather than on a specific vehicle, so it would be good to update the docs to fix this.

@Noiredd Noiredd self-assigned this Jan 20, 2025
@Noiredd Noiredd added the bug label Jan 20, 2025
@Noiredd Noiredd added this to the v1.3.1 milestone Jan 20, 2025
@Noiredd
Copy link
Owner

Noiredd commented Jan 20, 2025

I just regained access to my github account.

Apparently the code works as intended, i.e. we do check mission["launchAzimuth"] in line 59, just the docs are wrong. Thanks, marked it as bug and will add it to the next release (which will happen, don't let my empty contributions chart for last year fool you).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants