From 3f1483f95fa44be534d528b671098effc68387fb Mon Sep 17 00:00:00 2001
From: Liam Mackie <liam.mackie@octopus.com>
Date: Fri, 14 Feb 2025 09:30:26 +1000
Subject: [PATCH] PR feedback

---
 .../KubernetesAgentMigrateFromPreinstallationTest.cs  |  8 ++++----
 ...eInstalledKubernetesDeploymentTargetCommandTest.cs | 11 +++++++----
 2 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/source/Octopus.Tentacle.Kubernetes.Tests.Integration/KubernetesAgent/KubernetesAgentMigrateFromPreinstallationTest.cs b/source/Octopus.Tentacle.Kubernetes.Tests.Integration/KubernetesAgent/KubernetesAgentMigrateFromPreinstallationTest.cs
index 6ab668685..6fcde12f6 100644
--- a/source/Octopus.Tentacle.Kubernetes.Tests.Integration/KubernetesAgent/KubernetesAgentMigrateFromPreinstallationTest.cs
+++ b/source/Octopus.Tentacle.Kubernetes.Tests.Integration/KubernetesAgent/KubernetesAgentMigrateFromPreinstallationTest.cs
@@ -127,11 +127,11 @@ public async Task MigrationFromPreinstallHook_ShouldNotRunWhenTentacleIsAlreadyR
         var configMap = await client.CoreV1.ReadNamespacedConfigMapAsync(DestinationConfigMapName, commandNamespace);
         var secret = await client.CoreV1.ReadNamespacedSecretAsync(DestinationSecretName, commandNamespace);
 
-        configMap.Data.TryGetValue("validationKey", out var validationKeyFromKubernetes);
-        validationKeyFromKubernetes.Should().Be(validationKey);
+        configMap.Data.TryGetValue("validationKey", out var validationKeyFromKubernetesConfigMap);
+        validationKeyFromKubernetesConfigMap.Should().Be(validationKey);
         
-        secret.Data.TryGetValue("machine-key", out var hostKeyFromKubernetes);
-        hostKeyFromKubernetes.Should().Equal(Encoding.UTF8.GetBytes(validationKey));
+        secret.Data.TryGetValue("validationKey", out var validationKeyFromKubernetesSecret);
+        validationKeyFromKubernetesSecret.Should().Equal(Encoding.UTF8.GetBytes(validationKey));
     }
 
     async Task CreateCommandNamespace(string name)
diff --git a/source/Octopus.Tentacle.Tests/Commands/MigratePreInstalledKubernetesDeploymentTargetCommandTest.cs b/source/Octopus.Tentacle.Tests/Commands/MigratePreInstalledKubernetesDeploymentTargetCommandTest.cs
index eced28820..5090ce9c8 100644
--- a/source/Octopus.Tentacle.Tests/Commands/MigratePreInstalledKubernetesDeploymentTargetCommandTest.cs
+++ b/source/Octopus.Tentacle.Tests/Commands/MigratePreInstalledKubernetesDeploymentTargetCommandTest.cs
@@ -3,6 +3,7 @@
 using FluentAssertions;
 using k8s.Models;
 using NSubstitute;
+using NSubstitute.ExceptionExtensions;
 using NUnit.Framework;
 using Octopus.Tentacle.Commands;
 
@@ -16,12 +17,14 @@ public void ShouldNotMigrate_IfNoSource()
         {
             var targetConfigMap = Substitute.For<V1ConfigMap>();
             var targetSecret = Substitute.For<V1Secret>();
-            
-            MigratePreInstalledKubernetesDeploymentTargetCommand.ShouldMigrateData(null, null, targetConfigMap, targetSecret).Item1.Should().BeFalse();
+
+            var (shouldMigrate, reason) = MigratePreInstalledKubernetesDeploymentTargetCommand.ShouldMigrateData(null, null, targetConfigMap, targetSecret);
+            shouldMigrate.Should().BeFalse();
+            reason.Should().Be("Source config map or secret not found, skipping migration");
         }
         
         [Test]
-        public void ShouldNotMigrate_ifNoDestination()
+        public void ShouldNotMigrate_IfNoDestination()
         {
             var sourceConfigMap = Substitute.For<V1ConfigMap>();
             var sourceSecret = Substitute.For<V1Secret>();
@@ -30,7 +33,7 @@ public void ShouldNotMigrate_ifNoDestination()
         }
         
         [Test]
-        public void ShouldNotMigrate_ifDestinationRegistered()
+        public void ShouldNotMigrate_IfDestinationRegistered()
         {
             var sourceConfigMap = Substitute.For<V1ConfigMap>();
             var sourceSecret = Substitute.For<V1Secret>();