Skip to content
This repository has been archived by the owner on Sep 22, 2019. It is now read-only.

Return "Preferred" status in find_trees #55

Open
josephwb opened this issue Jun 16, 2016 · 4 comments
Open

Return "Preferred" status in find_trees #55

josephwb opened this issue Jun 16, 2016 · 4 comments

Comments

@josephwb
Copy link
Member

In making a call to find_trees, it would be very useful to return which tree(s) is "Preferred". In the nexson, this property is apparently called ot:candidateTreeForSynthesis.

If this property was present in the results of find_trees, then the newicks are just one call away. Otherwise, the nexson would have to be downloaded and parsed.

@jar398
Copy link
Member

jar398 commented Jun 16, 2016

If someone wants to tackle this, it's a very simple fix:

  1. add the property (ies) to
    ot-base/src/main/java/org/opentree/properties/OTVocabularyPredicate.java
  2. add it to
    oti/src/main/java/org/opentree/oti/indexproperties/IndexedPrimitiveProperties.java

@josephwb
Copy link
Member Author

Trying now.

@jar398
Copy link
Member

jar398 commented Jun 16, 2016

Getting it into the system is a more difficult proposition. I'll need to
rebuilt the taxomachine graphdb, restart taxomachine and oti, and reload
all the studies into oti. Any other fixes we should be doing at the same
time?

On Thu, Jun 16, 2016 at 1:47 PM, Joseph W. Brown [email protected]
wrote:

Trying now.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#55 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AB8QkkBUT3UMOsCuM2K_quqbMI7hwZN1ks5qMYxLgaJpZM4I3ndh
.

@josephwb
Copy link
Member Author

I don't have any other requests.

Both of your changes above are implemented and deployed on dev. Things compiled fine, but I cannot reindex.

./push.sh -c ../../deployed-systems/development/devapi.config index-db
host=devapi.opentreeoflife.org, admin=admin, pem=/home/josephwb/.ssh/opentree/opentree.pem, controller=josephwb
Syncing
as-admin.sh                                                       100% 9080     8.9KB/s   00:00    
Java 8 OK
Indexing studies from API at https://devapi.opentreeoflife.org/
Using the oti instance at: http://127.0.0.1:7478/db/data/
Using the studies from: https://devapi.opentreeoflife.org//../
Traceback (most recent call last):
  File "repo/oti/index_current_repo.py", line 77, in <module>
    main()
  File "repo/oti/index_current_repo.py", line 48, in main
    r.raise_for_status()
  File "/wd/opentree/venv/local/lib/python2.7/site-packages/requests/models.py", line 844, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://devapi.opentreeoflife.org//../study_list

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants