Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localizations do not have same master #7386

Open
MatteoPiovanelli opened this issue Nov 8, 2016 · 1 comment
Open

Localizations do not have same master #7386

MatteoPiovanelli opened this issue Nov 8, 2016 · 1 comment
Milestone

Comments

@MatteoPiovanelli
Copy link
Contributor

I noticed this behaviour, that in light of the recent discussions on localization #7352 we may want to change. I am writing it here in case we actually want to change this behaviour.
This is the scenario:

  • In a tenant enable 3+ cultures. In my example I have en-US, it-IT, fr-FR, de-DE.
  • Pick an en-US content item (I use the "Welcome to Orchard!" page) that I'll call enItem. Call its ID enID.
  • From enItem, create a new translation to the it-IT culture. Call the content item itItem, and its ID itID. In the localization records, you will see that the MasterContentItemId for itItem is enID.
  • From itItem, create a new translation to the fr-FR culture. Call the content item frItem, and its ID frID. In the localization records, you will see that the MasterContentItemID for frItem is itID.

The behaviour I would have expected was to have the MasterContentItemID for frItem to be enID, since that is the master for itItem.
As things stand, I could then create an en-US localization of frItem, because the localization part ignores the fact that itItem is already the translation of enItem.
On top of that, If I were to delete itItem I would lose all relations between enItem and frItem (I realize that the record would still be in the LocaliationPartRecord table).

I would suggest that the MasterContentItem is the same for all ContentItems in a translation set.

@sebastienros sebastienros added this to the Orchard 1.10.x milestone Nov 10, 2016
@sebastienros
Copy link
Member

This totally looks wrong. I think it would be logical to always use the same master id, but maybe it's by design,.
Let's ask @Jetski5822 what he thinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants