Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Song Duration Causes Scrobble Failures for Specific Tracks #165

Open
wanestar opened this issue Jan 14, 2025 · 0 comments
Open

Incorrect Song Duration Causes Scrobble Failures for Specific Tracks #165

wanestar opened this issue Jan 14, 2025 · 0 comments

Comments

@wanestar
Copy link

wanestar commented Jan 14, 2025 •
edited
Loading

Version Info
Latest versions for both
US Region

Describe the bug

Certain tracks (e.g., "Theia" and "Hot Water" by King Gizzard & The Lizard Wizard) are not being scrobbled correctly due to incorrect durations retrieved from metadata sources (Last.fm mainly, I think). The issue causes the IsTimeToScrobble logic to fail, as the SongDuration is either:

Incorrectly set to the duration of an extended version of the song
Unavailable or completely wrong (e.g., greater than 10 minutes or less than 30 seconds).
This prevents the scrobbling condition from being met, despite the song being played fully.

Steps to Reproduce
Play a track affected by the issue:
Example 1: "Theia" (actual duration 3:24 but retrieved as 12:00).
Example 2: "Hot Water" (actual duration 3:24 but retrieved as 7:35).

Log I added to me local build, See the song will never scrobble:
[IsTimeToScrobble] elapsedSeconds: 115, halfSongDuration: 371, SongDuration: 742, Condition Met: False.

You can tell its getting the duration from last.fm which is incorrect https://www.last.fm/music/King+Gizzard+&+The+Lizard+Wizard/_/Theia

Expected Behavior
The scrobbling logic should trigger after 50% of the song's actual duration or a fixed threshold (e.g., 120 seconds), regardless of metadata discrepancies, or after the song ends.

Official log from latest build ( api key removed)
Notice its using [GetSongDurationLastFm] and getting the incorrect duration, as last.fm is supplied by people and may be wrong it is probably better to prioritize Apple Music or even better the actual app it self.

[10:19:07] Application started
[10:19:07] Using region us
[10:19:07] No AMWin-RP updates available.
[10:19:07] No ListenBrainz user token found
[10:19:07] Could not find an AppleMusic.exe process
[10:19:07] Last.FM authentication succeeded
[10:19:12] Could not find an AppleMusic.exe process
[10:19:47] Previous message repeated 1 times
[10:19:47] [GetSongDurationLastFm] HTTP GET for http://ws.audioscrobbler.com/2.0/?method=track.getinfo&api_key=00000000000000&artist=King%20Gizzard%20%26%20The%20Lizard%20Wizard&track=Hot%20Water&format=json...
[10:19:47] [GetSongDurationLastFm] Request took 92ms
[10:19:47] [GetAlbumArtUrlLastFm] HTTP GET for http://ws.audioscrobbler.com/2.0/?method=album.getinfo&api_key=00000000000000&artist=King%20Gizzard%20%26%20The%20Lizard%20Wizard&album=I%27m%20In%20Your%20Mind%20Fuzz&format=json...
[10:19:47] [GetAlbumArtUrlLastFm] Request took 94ms
[10:19:47] [SearchSongs] HTTP GET for https://music.apple.com/us/search?term=Hot%20Water%20I%27m%20In%20Your%20Mind%20Fuzz%20King%20Gizzard%20%26%20The%20Lizard%20Wizard
[10:19:48] [SearchSongs] Request took 920ms
[10:19:48] [SearchSongs] No result found for Hot Water
[10:19:48] [SearchSongs] HTTP GET for https://music.apple.com/us/search?term=Hot%20Water%20I%27m%20In%20Your%20Mind%20Fuzz%20King%20Gizzard%20%26%20The%20Lizard%20Wizard
[10:19:50] [SearchSongs] Request took 1280ms
[10:19:50] [SearchSongs] No result found for Hot Water
[10:19:50] [SearchTopResults] HTTP GET for https://music.apple.com/us/search?term=Hot%20Water%20I%27m%20In%20Your%20Mind%20Fuzz%20King%20Gizzard%20%26%20The%20Lizard%20Wizard
[10:19:51] [SearchTopResults] Request took 957ms
[10:19:51] [SearchTopResults] Caching result for Hot Water
[10:19:51] [Last.FM scrobbler] New Song: King Gizzard & The Lizard WizardHot WaterI'm In Your Mind Fuzz
[10:19:52] [Last.FM scrobbler] Updated now playing: King Gizzard & The Lizard WizardHot WaterI'm In Your Mind Fuzz
[10:19:52] [SearchSongs] HTTP GET for https://music.apple.com/us/search?term=Hot%20Water%20I%27m%20In%20Your%20Mind%20Fuzz%20King%20Gizzard%20%26%20The%20Lizard%20Wizard
[10:19:53] Previous message repeated 1 times
[10:19:53] [SearchSongs] Request took 442ms
[10:19:53] [SearchSongs] No result found for Hot Water
[10:19:53] [SearchSongs] Request took 643ms
[10:19:53] [SearchSongs] No result found for Hot Water
[10:19:57] [SearchSongs] HTTP GET for https://music.apple.com/us/search?term=Hot%20Water%20I%27m%20In%20Your%20Mind%20Fuzz%20King%20Gizzard%20%26%20The%20Lizard%20Wizard
[10:19:57] [SearchSongs] Request took 401ms
[10:19:57] [SearchSongs] No result found for Hot Water
[10:20:02] [SearchSongs] HTTP GET for https://music.apple.com/us/search?term=Hot%20Water%20I%27m%20In%20Your%20Mind%20Fuzz%20King%20Gizzard%20%26%20The%20Lizard%20Wizard
[10:20:02] [SearchSongs] Request took 423ms
[10:20:02] [SearchSongs] No result found for Hot Water
[10:20:02] Reached max fails for GetArtistList.
[10:23:12] [GetSongDurationLastFm] HTTP GET for http://ws.audioscrobbler.com/2.0/?method=track.getinfo&api_key=00000000000000&artist=King%20Gizzard%20%26%20The%20Lizard%20Wizard&track=Theia&format=json...
[10:23:12] [GetSongDurationLastFm] Request took 116ms
[10:23:12] [GetAlbumArtUrlLastFm] HTTP GET for http://ws.audioscrobbler.com/2.0/?method=album.getinfo&api_key=00000000000000&artist=King%20Gizzard%20%26%20The%20Lizard%20Wizard&album=The%20Silver%20Cord&format=json...
[10:23:12] [GetAlbumArtUrlLastFm] Request took 99ms
[10:23:12] [SearchSongs] HTTP GET for https://music.apple.com/us/search?term=Theia%20The%20Silver%20Cord%20King%20Gizzard%20%26%20The%20Lizard%20Wizard
[10:23:13] [SearchSongs] Request took 702ms
[10:23:13] [SearchSongs] No result found for Theia
[10:23:13] [SearchSongs] HTTP GET for https://music.apple.com/us/search?term=Theia%20The%20Silver%20Cord%20King%20Gizzard%20%26%20The%20Lizard%20Wizard
[10:23:13] [SearchSongs] Request took 412ms
[10:23:13] [SearchSongs] No result found for Theia
[10:23:13] [SearchTopResults] HTTP GET for https://music.apple.com/us/search?term=Theia%20The%20Silver%20Cord%20King%20Gizzard%20%26%20The%20Lizard%20Wizard
[10:23:14] [SearchTopResults] Request took 296ms
[10:23:14] [SearchTopResults] Caching result for Theia
[10:23:14] [Last.FM scrobbler] New Song: King Gizzard & The Lizard WizardTheiaThe Silver Cord
[10:23:14] [Last.FM scrobbler] Updated now playing: King Gizzard & The Lizard WizardTheiaThe Silver Cord
[10:23:17] [SearchSongs] HTTP GET for https://music.apple.com/us/search?term=Theia%20The%20Silver%20Cord%20King%20Gizzard%20%26%20The%20Lizard%20Wizard
[10:23:17] [SearchSongs] Request took 270ms
[10:23:17] [SearchSongs] No result found for Theia
[10:23:22] [SearchSongs] HTTP GET for https://music.apple.com/us/search?term=Theia%20The%20Silver%20Cord%20King%20Gizzard%20%26%20The%20Lizard%20Wizard
[10:23:22] [SearchSongs] Request took 316ms
[10:23:22] [SearchSongs] No result found for Theia
[10:23:27] [SearchSongs] HTTP GET for https://music.apple.com/us/search?term=Theia%20The%20Silver%20Cord%20King%20Gizzard%20%26%20The%20Lizard%20Wizard
[10:23:27] [SearchSongs] Request took 286ms
[10:23:27] [SearchSongs] No result found for Theia
[10:23:32] [SearchSongs] HTTP GET for https://music.apple.com/us/search?term=Theia%20The%20Silver%20Cord%20King%20Gizzard%20%26%20The%20Lizard%20Wizard
[10:23:33] [SearchSongs] Request took 272ms
[10:23:33] [SearchSongs] No result found for Theia
[10:23:33] Reached max fails for GetArtistList.

And heres what one of the call returns as I removed my key:

Note: ,"duration":"455000" = 7 min and 35 seconds, when the actual song is 3 min 24 seconds.

[10:19:47] [GetSongDurationLastFm] HTTP GET for http://ws.audioscrobbler.com/2.0/?method=track.getinfo&api_key=00000000000000&artist=King%20Gizzard%20%26%20The%20Lizard%20Wizard&track=Hot%20Water&format=json...

{"track":{"name":"Hot Water","mbid":"261e5c9c-c6e0-46aa-884f-f2c4acc043e2","url":"https://www.last.fm/music/King+Gizzard+&+The+Lizard+Wizard/_/Hot+Water","duration":"455000","streamable":{"#text":"0","fulltrack":"0"},"listeners":"76773","playcount":"483923","artist":{"name":"King Gizzard & The Lizard Wizard","mbid":"f58384a4-2ad2-4f24-89c5-c7b74ae1cce7","url":"https://www.last.fm/music/King+Gizzard+&+The+Lizard+Wizard"},"album":{"artist":"King Gizzard & The Lizard Wizard","title":"I'm In Your Mind Fuzz","mbid":"c4f78d96-c742-4a01-9fb0-e6456161c7f7","url":"https://www.last.fm/music/King+Gizzard+&+The+Lizard+Wizard/I%27m+In+Your+Mind+Fuzz","image":[{"#text":"https://lastfm.freetls.fastly.net/i/u/34s/3f17671d88380e1665af8ef7f0f88d5b.png","size":"small"},{"#text":"https://lastfm.freetls.fastly.net/i/u/64s/3f17671d88380e1665af8ef7f0f88d5b.png","size":"medium"},{"#text":"https://lastfm.freetls.fastly.net/i/u/174s/3f17671d88380e1665af8ef7f0f88d5b.png","size":"large"},{"#text":"https://lastfm.freetls.fastly.net/i/u/300x300/3f17671d88380e1665af8ef7f0f88d5b.png","size":"extralarge"}],"@attr":{"position":"6"}},"toptags":{"tag":[{"name":"psychedelic","url":"https://www.last.fm/tag/psychedelic"},{"name":"pop","url":"https://www.last.fm/tag/pop"},{"name":"rock","url":"https://www.last.fm/tag/rock"},{"name":"hard rock","url":"https://www.last.fm/tag/hard+rock"},{"name":"Lo-Fi","url":"https://www.last.fm/tag/Lo-Fi"}]}}}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wanestar