Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building WDL-Forge sometimes produces a broken build #175

Open
forkiesassds opened this issue May 29, 2020 · 16 comments
Open

Building WDL-Forge sometimes produces a broken build #175

forkiesassds opened this issue May 29, 2020 · 16 comments
Labels

Comments

@forkiesassds
Copy link

When I load into a singleplayer world the game crashes, and joining any multiplayer servers causes this error Internal Exception: org.spongeporwered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
Singleplayer crashlog: https://hasteb.in/ojiqujug.yaml

@Pokechu22
Copy link
Owner

This is SpongePowered/MixinGradle#9. You should be able to build it properly if you use clean build instead of just build, in my experience. I remember this also affecting the litemod in the past. I should probably add a sanity check after building to make sure this doesn't happen.

@forkiesassds
Copy link
Author

So I properly followed the building instructions, and now the game works now.

@Pokechu22 Pokechu22 changed the title WDL-Forge errors out when MixinBootstrap is available. Building WDL-Forge sometimes produces a broken build May 30, 2020
@Pokechu22
Copy link
Owner

Good to hear that the build process works fine (apart from this issue). I'll keep this issue open until I fix the build problem.

@Tsoccerguy3
Copy link

2020-06-02_20 41 04

gradlew clean build compiles but the Forge builds dont load and produce the errors in picture

@Pokechu22
Copy link
Owner

Please read the message; there's a dependency you need to install (if you've got any suggestions on how to make it more obvious, other than including installation instructions in the forum post (which I plan to do), let me know).

@Tsoccerguy3
Copy link

2020-06-03_07 27 32

It's a good idea to post instructions including where to find the dependency. I have gradle extensions installed , but if there is something else , maybe add it to the compile instructions on the main page .
It complains about optifine but the same thing happens with or without optifine

@Pokechu22
Copy link
Owner

The dependency is MixinBootstrap, and it's linked in the error message on the last line. It's not actually needed to build (or run it in the development environment), only to run it when you've installed it elsewhere.

@Tsoccerguy3
Copy link

latest.log

still not sure what this bootstrap is supposed to do but when its in the mod folder can not connect , see log

@forkiesassds
Copy link
Author

when its in the mod folder can not connect

Try building it again using the same command line arguments.

@Tsoccerguy3
Copy link

should bootstrap jar be placed in the wdl folder some where for compile ?

@Pokechu22
Copy link
Owner

No; it's only needed at runtime (MixinBootstrap is what tells forge to load the mixins). You have it in the right place based on the error you're getting (MixinBootstrap loaded, at least).

The issue you have in the log (org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException: @Shadow field world was not located in the target class net.minecraft.client.network.play.ClientPlayNetHandler. Using refmap mixins.ForgeWDL.refmap.json) is the same one that this issue is about, and it's one I thought was resolved by using clean build. If clean build doesn't work, try first using clean, and then using build.

@Tsoccerguy3
Copy link

Hi Poke I tried multiple times to generate a Forge build , with no luck . I've followed your advise but no luck
debug.log

@Tsoccerguy3
Copy link

To be clear it builds with no errors , but can not log on to a server

@Pokechu22
Copy link
Owner

Try changing this line:

to @Shadow(aliases={"f", "field_147300_g"}) — that may help (but it really should not be needed)

@Tsoccerguy3
Copy link

That worked

@Pokechu22
Copy link
Owner

Well, I don't really have any idea why it's not remapping, so I'll just apply that workaround to all versions (this same thing has happened to me with the litemod in the past).

Pokechu22 added a commit that referenced this issue Jun 23, 2020
Prior to 1.13, the field was g; now it is f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants