Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose preventDefault in react hook #48

Open
myOmikron opened this issue Jul 10, 2024 · 1 comment
Open

expose preventDefault in react hook #48

myOmikron opened this issue Jul 10, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@myOmikron
Copy link

Is your feature request related to a problem? Please describe.
I'd like to have a custom Save function on CTRL + S but it opens the browser save dialog.
@RobertWHurst
Copy link
Owner

This seems like a reasonable desire indeed. I'll see if I can get to it in the near future, but at the moment I'm quite busy. If anyone wants to help with this I'm happy to take a look at PRs.

@RobertWHurst RobertWHurst added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 19, 2024
sytexa-julia added a commit to sytexa/Keystrokes that referenced this issue Jan 27, 2025
@sytexa-julia
feat: expose preventDefault in react hook (RobertWHurst#48)
9b0b7ff 
So as not to break the API I opted to make preventDefault an optional parameter on the useKey and useKeyCombo hooks (React) / composables (Vue)

test: added tests for the preventDefault option in useKey/useKeyCombo for React and Vue
fix: useKeyCombo Vue composable was not unbinding key combos correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RobertWHurst @myOmikron