Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 JS console errors on page load #51

Open
choldgraf opened this issue Mar 6, 2018 · 2 comments
Open

404 JS console errors on page load #51

choldgraf opened this issue Mar 6, 2018 · 2 comments

Comments

@choldgraf
Copy link

Just tried loading the nbinteract widgets and saw some errors I hadn't seen before. Just wanted to bring this to your attention @SamLau95 :-)

image

@SamLau95
Copy link
Owner

SamLau95 commented Mar 7, 2018

Thanks for bringing this up! We're aware of this issue; it happens when we check for a cached kernel that Binder has shut down for inactivity. We should just catch this error in the JS instead of letting it display a scary looking console message.

@SamLau95 SamLau95 changed the title Widgets seem to be down 404 JS console errors on page load Mar 8, 2018
@SamLau95
Copy link
Owner

SamLau95 commented Mar 8, 2018

Just took another look and we're catching the errors properly AFAIK but these errors are still showing up. On further investigation, it looks like these errors are automatically logged in the console even when we catch them in the JS: https://bugs.chromium.org/p/chromium/issues/detail?id=124534

It doesn't seem like we can get around this on our end—we have to make a request to Binder to check whether a kernel is still running but that URL returns a 404 if the server was already shut down.

@choldgraf - If there's a Binder API endpoint that returns the status of kernel given its ID we would be able to avoid making requests to nonexistent URLs. I put this as a low priority for me since everything is working as expected aside from some scary-looking console messages on startup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants