Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Shift(s): 869691f8 #6290

Open
github-actions bot opened this issue Jan 17, 2025 · 2 comments
Open

Performance Shift(s): 869691f8 #6290

github-actions bot opened this issue Jan 17, 2025 · 2 comments
Labels
Bot A bot generated issue/pull-request Type: Performance

Comments

@github-actions
Copy link
Contributor

Benchmark comparison has identified performance shifts at:

Please review the report below and take corrective/congratulatory action as appropriate :slightly_smiling_face:

⏱️ Performance Benchmark Report: 869691f

Performance shifts
| Change   | Before [331f012e] <main~1>   | After [869691f8] <main>   |   Ratio | Benchmark (Parameter)                                           |
|----------|------------------------------|---------------------------|---------|-----------------------------------------------------------------|
| +        | 39.0±0.5ms                   | 62.6±0.7ms                |    1.61 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(False) |
| +        | 39.9±0.4ms                   | 63.5±1ms                  |    1.59 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(True)  |
Full benchmark results

Benchmarks that have stayed the same:

| Change   | Before [331f012e] <main~1>   | After [869691f8] <main>   |   Ratio | Benchmark (Parameter)                                                                       |
|----------|------------------------------|---------------------------|---------|---------------------------------------------------------------------------------------------|
|          | 59.6±0.3ms                   | 57.4±1ms                  |    0.96 | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(False)                              |
|          | 60.3±1ms                     | 59.4±0.5ms                |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(True)                               |
|          | 210±2ms                      | 203±1ms                   |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(False)                    |
|          | 207±2ms                      | 204±2ms                   |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(True)                     |
|          | 38.5±0.3ms                   | 37.0±0.4ms                |    0.96 | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(False)                              |
|          | 39.4±0.4ms                   | 37.9±0.7ms                |    0.96 | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(True)                               |
|          | 38.5±0.5ms                   | 37.1±0.4ms                |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(False)                              |
|          | 39.7±0.4ms                   | 37.7±0.7ms                |    0.95 | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(True)                               |
|          | 51.6±0.5ms                   | 50.4±0.6ms                |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_MAX(False)                                |
|          | 52.7±1ms                     | 51.3±0.4ms                |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_MAX(True)                                 |
|          | 134±1ms                      | 131±1ms                   |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(False)                            |
|          | 133±1ms                      | 132±2ms                   |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(True)                             |
|          | 56.3±0.8ms                   | 54.8±0.2ms                |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(False)                               |
|          | 56.8±1ms                     | 55.2±0.7ms                |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(True)                                |
|          | 51.3±0.6ms                   | 50.3±0.8ms                |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_MIN(False)                                |
|          | 52.7±0.7ms                   | 51.2±1ms                  |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_MIN(True)                                 |
|          | 1.09±0.01s                   | 1.09±0.01s                |    1    | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(False)                               |
|          | 1.08±0.01s                   | 1.09±0.01s                |    1    | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(True)                                |
|          | 494±10ms                     | 494±20ms                  |    1    | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(False)                         |
|          | 495±10ms                     | 481±20ms                  |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(True)                          |
|          | 37.7±0.9ms                   | 36.1±0.7ms                |    0.96 | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(False)                         |
|          | 38.3±0.4ms                   | 36.7±0.9ms                |    0.96 | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(True)                          |
|          | 67.4±0.9ms                   | 65.6±0.8ms                |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_RMS(False)                                |
|          | 68.2±0.9ms                   | 66.1±0.7ms                |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_RMS(True)                                 |
|          | 71.7±0.7ms                   | 68.6±1ms                  |    0.96 | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(False)                            |
|          | 71.9±0.5ms                   | 70.0±1ms                  |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(True)                             |
|          | 66.3±1ms                     | 64.6±0.5ms                |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(False)                           |
|          | 67.4±0.6ms                   | 65.2±0.7ms                |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(True)                            |
|          | 26.3±0.6ms                   | 24.6±0.7ms                |    0.94 | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(False)                               |
|          | 30.3±0.6ms                   | 29.5±0.7ms                |    0.97 | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(True)                                |
|          | 144±2ms                      | 137±2ms                   |    0.95 | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(False)                     |
|          | 157±2ms                      | 151±1ms                   |    0.96 | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(True)                      |
|          | 23.9±0.7ms                   | 23.1±0.6ms                |    0.96 | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(False)                               |
|          | 28.2±0.6ms                   | 27.0±0.6ms                |    0.96 | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(True)                                |
|          | 23.6±0.5ms                   | 22.7±0.6ms                |    0.96 | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(False)                               |
|          | 28.3±0.3ms                   | 26.8±0.6ms                |    0.95 | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(True)                                |
|          | 24.8±0.4ms                   | 24.1±0.7ms                |    0.97 | aggregate_collapse.Aggregation.time_collapsed_by_MAX(False)                                 |
|          | 28.9±1ms                     | 28.3±0.7ms                |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_MAX(True)                                  |
|          | 37.3±0.6ms                   | 36.2±0.5ms                |    0.97 | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(False)                             |
|          | 42.0±0.7ms                   | 41.0±0.4ms                |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(True)                              |
|          | 25.3±0.5ms                   | 24.7±0.8ms                |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(False)                                |
|          | 29.4±0.7ms                   | 28.4±0.4ms                |    0.97 | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(True)                                 |
|          | 25.2±0.5ms                   | 26.8±0.4ms                |    1.07 | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(False)                              |
|          | 30.1±0.6ms                   | 31.1±0.7ms                |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(True)                               |
|          | 24.6±0.4ms                   | 24.1±0.4ms                |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_MIN(False)                                 |
|          | 29.0±0.7ms                   | 28.2±0.4ms                |    0.97 | aggregate_collapse.Aggregation.time_collapsed_by_MIN(True)                                  |
|          | 549±2ms                      | 549±4ms                   |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(False)                                |
|          | 553±3ms                      | 554±4ms                   |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(True)                                 |
|          | 158±3ms                      | 154±3ms                   |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(False)                          |
|          | 173±2ms                      | 172±2ms                   |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(True)                           |
|          | 23.2±0.6ms                   | 23.2±0.4ms                |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(False)                          |
|          | 28.1±0.5ms                   | 27.3±0.5ms                |    0.97 | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(True)                           |
|          | 26.8±0.6ms                   | 26.3±0.6ms                |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_RMS(False)                                 |
|          | 31.2±0.5ms                   | 30.9±0.7ms                |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_RMS(True)                                  |
|          | 26.7±0.5ms                   | 26.0±0.7ms                |    0.97 | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(False)                             |
|          | 31.0±0.4ms                   | 29.9±0.8ms                |    0.96 | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(True)                              |
|          | 26.0±0.5ms                   | 25.2±0.6ms                |    0.97 | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(False)                            |
|          | 29.8±0.7ms                   | 29.5±0.8ms                |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(True)                             |
|          | 92.0±0.9ms                   | 91.3±0.9ms                |    0.99 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(False)                     |
|          | 92.7±0.5ms                   | 91.8±0.5ms                |    0.99 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(True)                      |
|          | 104±0.8ms                    | 103±1ms                   |    0.99 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(False)                      |
|          | 105±1ms                      | 103±0.8ms                 |    0.98 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(True)                       |
|          | 62.1±1ms                     | 60.8±1ms                  |    0.98 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(False)                      |
|          | 62.6±0.8ms                   | 62.3±0.6ms                |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(True)                       |
|          | 30.3±0.4ms                   | 30.5±0.4ms                |    1.01 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(False)                      |
|          | 34.7±0.4ms                   | 34.5±0.6ms                |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(True)                       |
|          | 32.2±0.8ms                   | 32.2±0.5ms                |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(False)                       |
|          | 36.5±0.8ms                   | 35.5±0.9ms                |    0.97 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(True)                        |
|          | 26.2±0.6ms                   | 26.3±1ms                  |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(False)                       |
|          | 30.6±0.6ms                   | 30.3±0.8ms                |    0.99 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(True)                        |
|          | 316±3ms                      | 315±5ms                   |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(False)               |
|          | 336±3ms                      | 335±5ms                   |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(True)                |
|          | 1.14±0.01ms                  | 1.12±0.01ms               |    0.99 | cube.CubeCreation.time_create(False, 'construct')                                           |
|          | 411±2μs                      | 394±6μs                   |    0.96 | cube.CubeCreation.time_create(False, 'instantiate')                                         |
|          | 960±10μs                     | 953±10μs                  |    0.99 | cube.CubeCreation.time_create(True, 'construct')                                            |
|          | 594±8μs                      | 576±10μs                  |    0.97 | cube.CubeCreation.time_create(True, 'instantiate')                                          |
|          | 236±3ms                      | 236±4ms                   |    1    | cube.CubeEquality.time_equality(False, False, 'all_equal')                                  |
|          | 125±3ms                      | 125±2ms                   |    1    | cube.CubeEquality.time_equality(False, False, 'coord_inequality')                           |
|          | 261±6ms                      | 262±3ms                   |    1    | cube.CubeEquality.time_equality(False, False, 'data_inequality')                            |
|          | 16.7±0.2μs                   | 16.5±0.2μs                |    0.99 | cube.CubeEquality.time_equality(False, False, 'metadata_inequality')                        |
|          | 332±4ms                      | 330±3ms                   |    1    | cube.CubeEquality.time_equality(False, True, 'all_equal')                                   |
|          | 219±5ms                      | 217±4ms                   |    0.99 | cube.CubeEquality.time_equality(False, True, 'coord_inequality')                            |
|          | 356±4ms                      | 352±6ms                   |    0.99 | cube.CubeEquality.time_equality(False, True, 'data_inequality')                             |
|          | 17.0±0.3μs                   | 16.7±0.2μs                |    0.99 | cube.CubeEquality.time_equality(False, True, 'metadata_inequality')                         |
|          | 235±3ms                      | 234±4ms                   |    1    | cube.CubeEquality.time_equality(True, False, 'all_equal')                                   |
|          | 124±1ms                      | 125±2ms                   |    1.01 | cube.CubeEquality.time_equality(True, False, 'coord_inequality')                            |
|          | 263±4ms                      | 262±5ms                   |    1    | cube.CubeEquality.time_equality(True, False, 'data_inequality')                             |
|          | 53.4±0.3μs                   | 52.9±0.5μs                |    0.99 | cube.CubeEquality.time_equality(True, False, 'metadata_inequality')                         |
|          | 328±3ms                      | 328±5ms                   |    1    | cube.CubeEquality.time_equality(True, True, 'all_equal')                                    |
|          | 219±3ms                      | 216±4ms                   |    0.99 | cube.CubeEquality.time_equality(True, True, 'coord_inequality')                             |
|          | 355±6ms                      | 354±4ms                   |    1    | cube.CubeEquality.time_equality(True, True, 'data_inequality')                              |
|          | 55.8±0.6μs                   | 55.1±0.4μs                |    0.99 | cube.CubeEquality.time_equality(True, True, 'metadata_inequality')                          |
|          | 799±6μs                      | 789±6μs                   |    0.99 | import_iris.Iris.time__concatenate                                                          |
|          | 181±2μs                      | 187±7μs                   |    1.04 | import_iris.Iris.time__constraints                                                          |
|          | 109±2μs                      | 108±0.8μs                 |    0.99 | import_iris.Iris.time__data_manager                                                         |
|          | 92.0±1μs                     | 91.5±2μs                  |    0.99 | import_iris.Iris.time__deprecation                                                          |
|          | 135±1μs                      | 136±0.6μs                 |    1.01 | import_iris.Iris.time__lazy_data                                                            |
|          | 920±6μs                      | 914±4μs                   |    0.99 | import_iris.Iris.time__merge                                                                |
|          | 74.8±1μs                     | 75.4±0.8μs                |    1.01 | import_iris.Iris.time__representation                                                       |
|          | 596±7μs                      | 602±6μs                   |    1.01 | import_iris.Iris.time_analysis                                                              |
|          | 138±1μs                      | 139±1μs                   |    1.01 | import_iris.Iris.time_analysis__area_weighted                                               |
|          | 108±0.6μs                    | 107±1μs                   |    0.99 | import_iris.Iris.time_analysis__grid_angles                                                 |
|          | 243±2μs                      | 247±4μs                   |    1.02 | import_iris.Iris.time_analysis__interpolation                                               |
|          | 194±3μs                      | 188±1μs                   |    0.97 | import_iris.Iris.time_analysis__regrid                                                      |
|          | 110±0.6μs                    | 110±2μs                   |    1    | import_iris.Iris.time_analysis__scipy_interpolate                                           |
|          | 141±0.8μs                    | 136±2μs                   |    0.96 | import_iris.Iris.time_analysis_calculus                                                     |
|          | 335±2μs                      | 335±5μs                   |    1    | import_iris.Iris.time_analysis_cartography                                                  |
|          | 91.4±0.9μs                   | 92.5±2μs                  |    1.01 | import_iris.Iris.time_analysis_geomerty                                                     |
|          | 215±2μs                      | 217±5μs                   |    1.01 | import_iris.Iris.time_analysis_maths                                                        |
|          | 94.9±0.7μs                   | 96.1±1μs                  |    1.01 | import_iris.Iris.time_analysis_stats                                                        |
|          | 172±2μs                      | 172±2μs                   |    0.99 | import_iris.Iris.time_analysis_trajectory                                                   |
|          | 303±20μs                     | 315±7μs                   |    1.04 | import_iris.Iris.time_aux_factory                                                           |
|          | 82.6±0.8μs                   | 83.5±0.9μs                |    1.01 | import_iris.Iris.time_common                                                                |
|          | 162±1μs                      | 160±0.9μs                 |    0.99 | import_iris.Iris.time_common_lenient                                                        |
|          | 1.35±0.03ms                  | 1.38±0.02ms               |    1.02 | import_iris.Iris.time_common_metadata                                                       |
|          | 165±2μs                      | 163±2μs                   |    0.99 | import_iris.Iris.time_common_mixin                                                          |
|          | 1.21±0ms                     | 1.20±0.01ms               |    0.99 | import_iris.Iris.time_common_resolve                                                        |
|          | 197±1μs                      | 197±1μs                   |    1    | import_iris.Iris.time_config                                                                |
|          | 124±2μs                      | 125±2μs                   |    1.01 | import_iris.Iris.time_coord_categorisation                                                  |
|          | 365±5μs                      | 364±7μs                   |    1    | import_iris.Iris.time_coord_systems                                                         |
|          | 764±10μs                     | 751±9μs                   |    0.98 | import_iris.Iris.time_coords                                                                |
|          | 659±4μs                      | 669±8μs                   |    1.02 | import_iris.Iris.time_cube                                                                  |
|          | 223±2μs                      | 221±1μs                   |    0.99 | import_iris.Iris.time_exceptions                                                            |
|          | 75.2±0.3μs                   | 77.4±1μs                  |    1.03 | import_iris.Iris.time_experimental                                                          |
|          | 182±0.5μs                    | 188±4μs                   |    1.03 | import_iris.Iris.time_fileformats                                                           |
|          | 250±2μs                      | 252±2μs                   |    1.01 | import_iris.Iris.time_fileformats__ff                                                       |
|          | 2.65±0.02ms                  | 2.70±0.01ms               |    1.02 | import_iris.Iris.time_fileformats__ff_cross_references                                      |
|          | 77.0±0.4μs                   | 77.7±0.7μs                |    1.01 | import_iris.Iris.time_fileformats__pp_lbproc_pairs                                          |
|          | 112±0.4μs                    | 114±0.7μs                 |    1.02 | import_iris.Iris.time_fileformats_abf                                                       |
|          | 424±8μs                      | 415±2μs                   |    0.98 | import_iris.Iris.time_fileformats_cf                                                        |
|          | 4.83±0.06ms                  | 4.81±0.03ms               |    1    | import_iris.Iris.time_fileformats_dot                                                       |
|          | 72.9±0.7μs                   | 72.8±0.9μs                |    1    | import_iris.Iris.time_fileformats_name                                                      |
|          | 259±3μs                      | 261±1μs                   |    1.01 | import_iris.Iris.time_fileformats_name_loaders                                              |
|          | 119±1μs                      | 119±2μs                   |    1    | import_iris.Iris.time_fileformats_netcdf                                                    |
|          | 124±1μs                      | 122±1μs                   |    0.98 | import_iris.Iris.time_fileformats_nimrod                                                    |
|          | 219±2μs                      | 213±2μs                   |    0.97 | import_iris.Iris.time_fileformats_nimrod_load_rules                                         |
|          | 791±4μs                      | 786±8μs                   |    0.99 | import_iris.Iris.time_fileformats_pp                                                        |
|          | 179±2μs                      | 182±4μs                   |    1.02 | import_iris.Iris.time_fileformats_pp_load_rules                                             |
|          | 134±0.9μs                    | 132±0.4μs                 |    0.99 | import_iris.Iris.time_fileformats_pp_save_rules                                             |
|          | 556±2μs                      | 551±4μs                   |    0.99 | import_iris.Iris.time_fileformats_rules                                                     |
|          | 217±2μs                      | 218±2μs                   |    1    | import_iris.Iris.time_fileformats_structured_array_identification                           |
|          | 83.0±0.6μs                   | 82.2±0.3μs                |    0.99 | import_iris.Iris.time_fileformats_um                                                        |
|          | 158±2μs                      | 165±2μs                   |    1.04 | import_iris.Iris.time_fileformats_um__fast_load                                             |
|          | 137±4μs                      | 135±1μs                   |    0.99 | import_iris.Iris.time_fileformats_um__fast_load_structured_fields                           |
|          | 74.1±0.4μs                   | 74.3±0.7μs                |    1    | import_iris.Iris.time_fileformats_um__ff_replacement                                        |
|          | 80.8±0.6μs                   | 79.4±0.4μs                |    0.98 | import_iris.Iris.time_fileformats_um__optimal_array_structuring                             |
|          | 994±3μs                      | 980±20μs                  |    0.99 | import_iris.Iris.time_fileformats_um_cf_map                                                 |
|          | 134±1μs                      | 134±2μs                   |    1    | import_iris.Iris.time_io                                                                    |
|          | 174±1μs                      | 171±2μs                   |    0.98 | import_iris.Iris.time_io_format_picker                                                      |
|          | 296±4μs                      | 295±2μs                   |    1    | import_iris.Iris.time_iris                                                                  |
|          | 126±0.4μs                    | 126±0.7μs                 |    1.01 | import_iris.Iris.time_iterate                                                               |
|          | 8.15±0.04ms                  | 8.11±0.04ms               |    0.99 | import_iris.Iris.time_palette                                                               |
|          | 1.92±0.01ms                  | 1.92±0.04ms               |    1    | import_iris.Iris.time_plot                                                                  |
|          | 104±1μs                      | 103±2μs                   |    0.99 | import_iris.Iris.time_quickplot                                                             |
|          | 2.22±0.02ms                  | 2.19±0.03ms               |    0.99 | import_iris.Iris.time_std_names                                                             |
|          | 1.80±0.01ms                  | 1.78±0.01ms               |    0.99 | import_iris.Iris.time_symbols                                                               |
|          | 274±10ms                     | 273±1ms                   |    1    | import_iris.Iris.time_tests                                                                 |
|          | 269±0.9μs                    | 267±2μs                   |    0.99 | import_iris.Iris.time_third_party_cartopy                                                   |
|          | 4.94±0.02ms                  | 4.97±0.03ms               |    1.01 | import_iris.Iris.time_third_party_cf_units                                                  |
|          | 127±2μs                      | 125±2μs                   |    0.99 | import_iris.Iris.time_third_party_cftime                                                    |
|          | 2.93±0.01ms                  | 2.92±0.01ms               |    1    | import_iris.Iris.time_third_party_matplotlib                                                |
|          | 1.28±0ms                     | 1.29±0.01ms               |    1.01 | import_iris.Iris.time_third_party_numpy                                                     |
|          | 185±4μs                      | 180±3μs                   |    0.97 | import_iris.Iris.time_third_party_scipy                                                     |
|          | 98.2±0.8μs                   | 98.2±0.4μs                |    1    | import_iris.Iris.time_time                                                                  |
|          | 344±3μs                      | 339±3μs                   |    0.99 | import_iris.Iris.time_util                                                                  |
|          | 72.1±0.6μs                   | 72.2±1μs                  |    1    | iterate.IZip.time_izip                                                                      |
|          | 10.3±0.04ms                  | 10.2±0.06ms               |    0.98 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'FF')                                  |
|          | 25.4±0.6ms                   | 24.9±0.4ms                |    0.98 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'NetCDF')                              |
|          | 10.2±0.08ms                  | 10.1±0.04ms               |    0.99 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'PP')                                  |
|          | 10.1±0.1ms                   | 10.1±0.04ms               |    1    | load.LoadAndRealise.time_load((1280, 960, 5), True, 'FF')                                   |
|          | 22.8±0.2ms                   | 22.7±0.3ms                |    0.99 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'NetCDF')                               |
|          | 10.3±0.2ms                   | 10.4±0.1ms                |    1.01 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'PP')                                   |
|          | 1.62±0.02s                   | 1.60±0.02s                |    0.99 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'FF')                                    |
|          | 22.9±0.2ms                   | 23.0±0.3ms                |    1.01 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'NetCDF')                                |
|          | 1.62±0.01s                   | 1.60±0.02s                |    0.99 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'PP')                                    |
|          | 1.62±0.01s                   | 1.61±0.01s                |    0.99 | load.LoadAndRealise.time_load((2, 2, 1000), True, 'FF')                                     |
|          | 22.9±0.3ms                   | 23.0±0.4ms                |    1    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'NetCDF')                                 |
|          | 1.63±0.01s                   | 1.61±0.01s                |    0.99 | load.LoadAndRealise.time_load((2, 2, 1000), True, 'PP')                                     |
|          | 5.32±0.05ms                  | 5.20±0.04ms               |    0.98 | load.LoadAndRealise.time_load((50, 50, 2), False, 'FF')                                     |
|          | 21.7±0.2ms                   | 21.1±0.4ms                |    0.97 | load.LoadAndRealise.time_load((50, 50, 2), False, 'NetCDF')                                 |
|          | 5.34±0.05ms                  | 5.19±0.06ms               |    0.97 | load.LoadAndRealise.time_load((50, 50, 2), False, 'PP')                                     |
|          | 5.21±0.02ms                  | 5.23±0.1ms                |    1    | load.LoadAndRealise.time_load((50, 50, 2), True, 'FF')                                      |
|          | 21.3±0.5ms                   | 21.8±0.3ms                |    1.02 | load.LoadAndRealise.time_load((50, 50, 2), True, 'NetCDF')                                  |
|          | 5.18±0.04ms                  | 5.16±0.03ms               |    1    | load.LoadAndRealise.time_load((50, 50, 2), True, 'PP')                                      |
|          | 23.9±1ms                     | 23.8±1ms                  |    1    | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'FF')                               |
|          | 20.1±0.4ms                   | 20.2±0.4ms                |    1.01 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'NetCDF')                           |
|          | 12.0±0.6ms                   | 12.1±1ms                  |    1    | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'PP')                               |
|          | 27.5±0.8ms                   | 27.5±2ms                  |    1    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'FF')                                |
|          | 69.9±1ms                     | 69.8±0.9ms                |    1    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'NetCDF')                            |
|          | 26.6±0.8ms                   | 26.9±0.7ms                |    1.01 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'PP')                                |
|          | 496±7ms                      | 499±9ms                   |    1    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'FF')                                 |
|          | 3.13±0.09ms                  | 2.99±0.09ms               |    0.96 | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'NetCDF')                             |
|          | 494±6ms                      | 487±9ms                   |    0.99 | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'PP')                                 |
|          | 505±6ms                      | 497±8ms                   |    0.99 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'FF')                                  |
|          | 3.09±0.2ms                   | 3.06±0.1ms                |    0.99 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'NetCDF')                              |
|          | 504±4ms                      | 498±10ms                  |    0.99 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'PP')                                  |
|          | 1.66±0.07ms                  | 1.67±0.04ms               |    1    | load.LoadAndRealise.time_realise((50, 50, 2), False, 'FF')                                  |
|          | 3.07±0.08ms                  | 3.06±0.1ms                |    1    | load.LoadAndRealise.time_realise((50, 50, 2), False, 'NetCDF')                              |
|          | 1.71±0.04ms                  | 1.64±0.06ms               |    0.96 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'PP')                                  |
|          | 1.72±0.09ms                  | 1.75±0.09ms               |    1.02 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'FF')                                   |
|          | 3.14±0.2ms                   | 3.11±0.2ms                |    0.99 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'NetCDF')                               |
|          | 1.77±0.04ms                  | 1.75±0.05ms               |    0.99 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'PP')                                   |
|          | 371±1ms                      | 370±5ms                   |    1    | load.ManyVars.time_many_var_load                                                            |
|          | 10.5±0.1ms                   | 10.2±0.1ms                |    0.97 | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'FF')                            |
|          | 10.3±0.1ms                   | 10.3±0.1ms                |    1    | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'PP')                            |
|          | 1.63±0.02s                   | 1.62±0.02s                |    0.99 | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'FF')                              |
|          | 1.65±0.01s                   | 1.63±0.01s                |    0.99 | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'PP')                              |
|          | 5.32±0.05ms                  | 5.30±0.09ms               |    1    | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'FF')                                 |
|          | 5.29±0.08ms                  | 5.18±0.04ms               |    0.98 | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'PP')                                 |
|          | 9.50±0.1ms                   | 9.29±0.1ms                |    0.98 | load.StructuredFF.time_structured_load((1280, 960, 5), False)                               |
|          | 6.12±0.02ms                  | 5.97±0.06ms               |    0.98 | load.StructuredFF.time_structured_load((1280, 960, 5), True)                                |
|          | 1.62±0.01s                   | 1.60±0.01s                |    0.99 | load.StructuredFF.time_structured_load((2, 2, 1000), False)                                 |
|          | 560±9ms                      | 561±10ms                  |    1    | load.StructuredFF.time_structured_load((2, 2, 1000), True)                                  |
|          | 4.43±0.02ms                  | 4.40±0.03ms               |    0.99 | load.StructuredFF.time_structured_load((2, 2, 2), False)                                    |
|          | 4.29±0.03ms                  | 4.23±0.02ms               |    0.99 | load.StructuredFF.time_structured_load((2, 2, 2), True)                                     |
|          | 175±1ms                      | 174±2ms                   |    1    | load.TimeConstraint.time_time_constraint(20, 'FF')                                          |
|          | 24.9±0.4ms                   | 24.7±0.3ms                |    0.99 | load.TimeConstraint.time_time_constraint(20, 'NetCDF')                                      |
|          | 173±2ms                      | 174±0.8ms                 |    1    | load.TimeConstraint.time_time_constraint(20, 'PP')                                          |
|          | 34.5±0.6ms                   | 34.1±0.3ms                |    0.99 | load.TimeConstraint.time_time_constraint(3, 'FF')                                           |
|          | 24.6±0.3ms                   | 24.1±0.4ms                |    0.98 | load.TimeConstraint.time_time_constraint(3, 'NetCDF')                                       |
|          | 34.4±0.2ms                   | 34.4±0.6ms                |    1    | load.TimeConstraint.time_time_constraint(3, 'PP')                                           |
|          | 20.0±0.4ms                   | 19.7±0.3ms                |    0.99 | load.ugrid.BasicLoading.time_load_file(1)                                                   |
|          | 56.3±0.6ms                   | 56.7±0.9ms                |    1.01 | load.ugrid.BasicLoading.time_load_file(200000)                                              |
|          | 15.0±0.3ms                   | 15.3±0.4ms                |    1.02 | load.ugrid.BasicLoading.time_load_mesh(1)                                                   |
|          | 24.7±0.8ms                   | 24.0±1ms                  |    0.97 | load.ugrid.BasicLoading.time_load_mesh(200000)                                              |
|          | 20.3±0.3ms                   | 19.9±0.4ms                |    0.98 | load.ugrid.BasicLoadingTime.time_load_file(1)                                               |
|          | 23.0±0.4ms                   | 22.8±1ms                  |    0.99 | load.ugrid.BasicLoadingTime.time_load_file(200000)                                          |
|          | 15.0±0.3ms                   | 15.2±0.4ms                |    1.01 | load.ugrid.BasicLoadingTime.time_load_mesh(1)                                               |
|          | 18.4±0.5ms                   | 18.2±1ms                  |    0.99 | load.ugrid.BasicLoadingTime.time_load_mesh(200000)                                          |
|          | 20.8±0.4ms                   | 21.0±0.2ms                |    1.01 | load.ugrid.Callback.time_load_file_callback(1)                                              |
|          | 66.6±1ms                     | 66.3±0.5ms                |    0.99 | load.ugrid.Callback.time_load_file_callback(200000)                                         |
|          | 20.7±0.3ms                   | 20.8±0.8ms                |    1.01 | load.ugrid.CallbackTime.time_load_file_callback(1)                                          |
|          | 25.1±0.6ms                   | 25.4±1ms                  |    1.01 | load.ugrid.CallbackTime.time_load_file_callback(200000)                                     |
|          | 3.20±0.2ms                   | 3.08±0.2ms                |    0.96 | load.ugrid.DataRealisation.time_realise_data(10000)                                         |
|          | 4.44±0.2ms                   | 4.39±0.2ms                |    0.99 | load.ugrid.DataRealisation.time_realise_data(200000)                                        |
|          | 38.6±1ms                     | 39.6±2ms                  |    1.03 | load.ugrid.DataRealisationTime.time_realise_data(10000)                                     |
|          | 781±9ms                      | 775±30ms                  |    0.99 | load.ugrid.DataRealisationTime.time_realise_data(200000)                                    |
|          | 444±4ms                      | 440±5ms                   |    0.99 | merge_concat.Concatenate.time_concatenate(False)                                            |
|          | 446±5ms                      | 440±5ms                   |    0.99 | merge_concat.Concatenate.time_concatenate(True)                                             |
|          | 109±0.3M                     | 109±0.5M                  |    1    | merge_concat.Concatenate.tracemalloc_concatenate(False)                                     |
|          | 109±0.3M                     | 109±0.5M                  |    1    | merge_concat.Concatenate.tracemalloc_concatenate(True)                                      |
|          | 51.6±1ms                     | 51.2±2ms                  |    0.99 | merge_concat.Merge.time_merge                                                               |
|          | 1.62±0.2M                    | 1.62±0.2M                 |    1    | merge_concat.Merge.tracemalloc_merge                                                        |
|          | 404±3ns                      | 403±4ns                   |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(50)              |
|          | 211±0.6ms                    | 214±4ms                   |    1.01 | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(500)             |
|          | 650±0.1k                     | 650±0.3k                  |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(50)       |
|          | 60.1±0M                      | 60.1±0M                   |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(500)      |
|          | 18.0±0.2ms                   | 17.6±0.3ms                |    0.98 | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(50)           |
|          | 19.9±0.2ms                   | 20.0±0.3ms                |    1.01 | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(500)          |
|          | 697±50k                      | 698±50k                   |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(50)    |
|          | 12.6±0.05M                   | 12.6±0.05M                |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(500)   |
|          | 108±3ms                      | 107±1ms                   |    0.99 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(50)         |
|          | 599±4ms                      | 598±8ms                   |    1    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(500)        |
|          | 1.24±0.05M                   | 1.24±0.05M                |    0.99 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(50)  |
|          | 96.2±0.04M                   | 96.3±0.01M                |    1    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(500) |
|          | 69.0±1ms                     | 67.4±2ms                  |    0.98 | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(50)                             |
|          | 552±5ms                      | 552±7ms                   |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(500)                            |
|          | 1.17±0.01M                   | 1.18±0.01M                |    1.01 | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(50)                      |
|          | 96.2±0.02M                   | 96.2±0.02M                |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(500)                     |
|          | 2.1752849999999997           | 2.1752849999999997        |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(50)                  |
|          | 216.01528499999998           | 216.01528499999998        |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(500)                 |
|          | 6.76±0.06ms                  | 6.67±0.03ms               |    0.99 | plot.AuxSort.time_aux_sort                                                                  |
|          | 78.3±4ms                     | 80.3±3ms                  |    1.03 | regridding.CurvilinearRegridding.time_regrid_pic                                            |
|          | 136±3M                       | 136±3M                    |    1    | regridding.CurvilinearRegridding.tracemalloc_regrid_pic                                     |
|          | 101±1ms                      | 99.7±1ms                  |    0.99 | regridding.HorizontalChunkedRegridding.time_regrid_area_w                                   |
|          | 49.6±3ms                     | 52.4±2ms                  |    1.06 | regridding.HorizontalChunkedRegridding.time_regrid_area_w_new_grid                          |
|          | 106±0.05M                    | 106±0.04M                 |    1    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w                            |
|          | 147±0.02M                    | 147±0.02M                 |    1    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w_new_grid                   |
|          | 4.56±0.01ms                  | 4.54±0.04ms               |    1    | save.NetcdfSave.time_netcdf_save_cube(50, False)                                            |
|          | 76.8±1ms                     | 76.4±1ms                  |    0.99 | save.NetcdfSave.time_netcdf_save_cube(50, True)                                             |
|          | 43.6±0.7ms                   | 42.7±1ms                  |    0.98 | save.NetcdfSave.time_netcdf_save_cube(600, False)                                           |
|          | 491±5ms                      | 487±10ms                  |    0.99 | save.NetcdfSave.time_netcdf_save_cube(600, True)                                            |
|          | 87.1±0.7ns                   | 88.0±1ns                  |    1.01 | save.NetcdfSave.time_netcdf_save_mesh(50, False)                                            |
|          | 57.2±2ms                     | 58.1±2ms                  |    1.02 | save.NetcdfSave.time_netcdf_save_mesh(50, True)                                             |
|          | 87.2±3ns                     | 87.5±0.5ns                |    1    | save.NetcdfSave.time_netcdf_save_mesh(600, False)                                           |
|          | 432±10ms                     | 436±9ms                   |    1.01 | save.NetcdfSave.time_netcdf_save_mesh(600, True)                                            |
|          | 30.3±0.08k                   | 30.3±0.06k                |    1    | save.NetcdfSave.tracemalloc_netcdf_save(50, False)                                          |
|          | 1.71±0.2M                    | 1.71±0.1M                 |    1    | save.NetcdfSave.tracemalloc_netcdf_save(50, True)                                           |
|          | 30.3±0.06k                   | 30.3±0.05k                |    1    | save.NetcdfSave.tracemalloc_netcdf_save(600, False)                                         |
|          | 190±20M                      | 190±20M                   |    1    | save.NetcdfSave.tracemalloc_netcdf_save(600, True)                                          |
|          | 41.7±0.3ms                   | 40.9±0.5ms                |    0.98 | stats.PearsonR.time_lazy                                                                    |
|          | 9.40±0.3ms                   | 9.07±0.3ms                |    0.97 | stats.PearsonR.time_real                                                                    |
|          | 24.1±1M                      | 24.6±1M                   |    1.02 | stats.PearsonR.tracemalloc_lazy                                                             |
|          | 18.4±0.01M                   | 18.4±0.01M                |    1    | stats.PearsonR.tracemalloc_real                                                             |
|          | 26.5±0.4ms                   | 25.6±2ms                  |    0.96 | trajectory.TrajectoryInterpolation.time_trajectory_linear                                   |
|          | 68.4±1ms                     | 67.1±2ms                  |    0.98 | trajectory.TrajectoryInterpolation.time_trajectory_nearest                                  |
|          | 23.3±0.01M                   | 23.3±0.01M                |    1    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_linear                            |
|          | 12.1±0.04M                   | 12.1±0.04M                |    1    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_nearest                           |

Benchmarks that have got worse:

| Change   | Before [331f012e] <main~1>   | After [869691f8] <main>   |   Ratio | Benchmark (Parameter)                                           |
|----------|------------------------------|---------------------------|---------|-----------------------------------------------------------------|
| +        | 39.0±0.5ms                   | 62.6±0.7ms                |    1.61 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(False) |
| +        | 39.9±0.4ms                   | 63.5±1ms                  |    1.59 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(True)  |

Generated by GHA run 12838187817

@github-actions github-actions bot added Bot A bot generated issue/pull-request Type: Performance labels Jan 17, 2025
@pp-mo
Copy link
Member

pp-mo commented Jan 20, 2025

I thought this might still be worth a little look.
But just running the benchmarks here achieves nothing now, since it compares to main which already has the commit.
I guess we can try run a reversion PR ?

@pp-mo
Copy link
Member

pp-mo commented Jan 20, 2025

we can try run a reversion PR ?

I think that shows a significant effect :
It really does take 60% longer with the new code, so this might be worth looking into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot A bot generated issue/pull-request Type: Performance
Projects
Status: No status
Development

No branches or pull requests

1 participant