Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rrequirements seem to be not complete #191

Open
jalovisko opened this issue Jul 5, 2021 · 1 comment
Open

Rrequirements seem to be not complete #191

jalovisko opened this issue Jul 5, 2021 · 1 comment

Comments

@jalovisko
Copy link

The requirements in the documentation do not seem to be complete. Ideally, it would be even better to specify versions of the libraries used because there is no guarantee that any future version of a dependency would not break the whole project. I feel like defining these dependencies further with versions in the documentation and in the requirements.txt is better way to go. I have found the set of requiremnts that seem to be working well on Linux and I can make a PR with them.

@petterreinholdtsen
Copy link
Contributor

Why do you ask, instead of just creating the PR to let others have a look at your proposal? Locking versions to a specific one will block any security fixes in dependencies to flow automatically into new installations, so there is a downside to fixed versions in requirements too. No idea which feature is most important here, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants