Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOGS[FE]: Pagination changes in logs FE #6957

Open
nityanandagohain opened this issue Jan 29, 2025 · 0 comments
Open

LOGS[FE]: Pagination changes in logs FE #6957

nityanandagohain opened this issue Jan 29, 2025 · 0 comments
Assignees
Labels
events-pod events pod

Comments

@nityanandagohain
Copy link
Member

nityanandagohain commented Jan 29, 2025

Pagination changes in logs FE.

As of now in logs when the order by is timestamp. We do pagination using id in the filters ( eg: id < last log seen). If the order by is changed to something else then we do pagination using limit and pageSize.

With this change. when the order by is timestamp

  • We will remove id filter during pagination
  • Using limit and pagesize as for other order by
  • and in the payload pass order by as timestamp, id. Hide id from the UI
     "orderBy": [
                      {
                          "columnName": "timestamp",
                          "order": "ASC"
                      },
                      {
                          "columnName": "id",
                          "order": "ASC"
                      }
                  ],
    

Example query with offset 100

{
    "start": 1738059169000,
    "end": 1738080769000,
    "step": 60,
    "variables": {},
    "compositeQuery": {
        "queryType": "builder",
        "panelType": "list",
        "fillGaps": false,
        "builderQueries": {
            "A": {
                "dataSource": "logs",
                "queryName": "A",
                "aggregateOperator": "noop",
                "aggregateAttribute": {
                    "id": "------false",
                    "dataType": "",
                    "key": "",
                    "isColumn": false,
                    "type": "",
                    "isJSON": false
                },
                "timeAggregation": "rate",
                "spaceAggregation": "sum",
                "functions": [],
                "filters": {
                    "items": [],
                    "op": "AND"
                },
                "expression": "A",
                "disabled": false,
                "stepInterval": 60,
                "having": [],
                "limit": null,
                "orderBy": [
                    {
                        "columnName": "timestamp",
                        "order": "ASC"
                    },
                    {
                        "columnName": "id",
                        "order": "ASC"
                    }
                ],
                "groupBy": [],
                "legend": "",
                "reduceTo": "avg",
                "offset": 100,
                "pageSize": 100
            }
        }
    }
}```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
events-pod events pod
Projects
None yet
Development

No branches or pull requests

2 participants