Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magento 2.4.8-beta1 compatibility #3518

Closed
Bashev opened this issue Feb 11, 2025 · 1 comment · Fixed by #3520
Closed

Magento 2.4.8-beta1 compatibility #3518

Bashev opened this issue Feb 11, 2025 · 1 comment · Fixed by #3520

Comments

@Bashev
Copy link
Contributor

Bashev commented Feb 11, 2025

Preconditions

Magento Version : 2.4.8-beta1

ElasticSuite Version : 2.11.10

Environment : New installation

Third party modules : No

Steps to reproduce

  1. Install/Update Magento 2.4.8-beta1
  2. Install Elasticsuite

Expected result

Successful install/update

Actual result

Because of this PR: magento/magento2@7a737ae magento looks for type for every column in db_schema.xml but in src/module-elasticsuite-catalog/etc/db_schema.xml these two:

        <column name="is_used_in_autocomplete" disabled="true"/>
        <column name="is_display_rel_no_follow" disabled="true"/>

are disabled, and haven't type. I can create PR, but i'm not sure, are they need to have type, or they are deprecated and going to be deleted.
@romainruaud
Copy link
Collaborator

These columns are meant to be removed, so I think giving them a type is safe, and we'll remove them later on. They were supposed to be boolean (tinyint).

Can you propose a PR ?

Regards

@Bashev Bashev mentioned this issue Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add column type in db_schema.xml, required from magento 2.4.8-beta1 Bashev/elasticsuite
2 participants
@Bashev @romainruaud