Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a Github action bot that automatically does the file formatting. #35

Open
rahul799 opened this issue Jun 13, 2020 · 12 comments · May be fixed by #37
Open

Make a Github action bot that automatically does the file formatting. #35

rahul799 opened this issue Jun 13, 2020 · 12 comments · May be fixed by #37

Comments

@rahul799
Copy link
Member

Is your feature request related to a problem? Please describe.

By using Github Action & Prettier, make a workflow that is automatically triggered when particular file formats (which are supported by prettier like .HTML,.css.js, etc) are altered in the PR. For reference, you can go through this article .

Describe the solution you'd like
A GH action that automatically applies prettier on all HTML, CSS & JS files.

@sovoid
Copy link

sovoid commented Jun 13, 2020

This can be added as a feature to our NLP bot

@rahul799
Copy link
Member Author

Ya... Can do.

@sovoid
Copy link

sovoid commented Jun 13, 2020

Let us work on this right now....we will prolly migrate it to the bot later when its live

@rahul799
Copy link
Member Author

Guys, whoever wants to work on this project, please note that the workflow may not work in the forked repo, so you can make a sandbox repo or let me know if you face any problem.

@Kushagraw12
Copy link
Contributor

Can i take up this issue?

@sovoid
Copy link

sovoid commented Jun 13, 2020

Sure @Kushagraw12 , your first patch should contain a basic README on your proposed flow.

@sovoid
Copy link

sovoid commented Jun 13, 2020

Feel free to add any one of the mentors as reviewers once up 😁

@Kushagraw12
Copy link
Contributor

Okkay, sure! Will work on that!

@tushar5526
Copy link
Member

tushar5526 commented Jun 14, 2020

Hey, @Kushagraw12 we can work on this together. Are you familiar with github-actions ? I am familiar
with basic Devops ( Docker and jenkins )

@tushar5526
Copy link
Member

@rahul799 @und3fined-v01d
Is this the intended behaviour ?
take a look : github action for this website clone
I have initialised node here and installed prettier before hand.

@rahul799
Copy link
Member Author

Good job tushar.

@rahul799
Copy link
Member Author

I have few more tasks for you & will let you know when you will make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants