Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or scope down FileSystemHandle.moveTo() #53

Closed
pwnall opened this issue May 16, 2019 · 1 comment
Closed

Remove or scope down FileSystemHandle.moveTo() #53

pwnall opened this issue May 16, 2019 · 1 comment
Milestone

Comments

@pwnall
Copy link
Collaborator

pwnall commented May 16, 2019

FileSystemHandle.moveTo() is a new capability when it can carry out the move atomically. If the source and the target are in different file systems, the implementation needs to fall back to copying FileSystemHandle.copyTo() and removing (FileSystemHandle.remove() / FileSystemDirectoryHandle.removeRecursively()).

In #52 I argue that we shouldn't provide copyTo(). I think the argument applies here as well. I think we should either nix moveTo() for now, or scope it down to the new capability. In the latter case, we'd have the method fail if the move cannot be performed atomically.

@pwnall
Copy link
Collaborator Author

pwnall commented Jun 3, 2019

I think this was fixed in #50

@pwnall pwnall closed this as completed Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants