Trouble implementing view mouse resizing in my tiling plugin. #1108

Javyre · 2021-03-06T16:15:24Z

Javyre
Mar 6, 2021

Hey, I'm making a tiling window manager plugin for wayfire intended to imitate sway/i3 more closely than simple-tile.

I'm having some trouble implementing interactive resizing using the mouse. The views seem to lag behind when their geometry is set it doesn't apply it right away and so getting their geometry with get_wm_geometry is unreliable as well.

Using set_resize helps in certain simple cases when there is only one view resizing, but it doesn't fully solve the issue when resizing multiple views at the same time when they are tiled together. Using set_resize also gets very complicated in a more complex interactive resize motion.

I didn't file this as a bug since it seems to be semi-documented behaviour that you seem to account for in the simple-tile plugin here:

wayfire/plugins/tile/tree.cpp

Lines 260 to 301 in 8481e87

    
           /** 
        
            * A simple transformer to scale and translate the view in such a way that 
        
            * its displayed wm geometry region is a specified box on the screen 
        
            */ 
        
           static const std::string scale_transformer_name = 
        
               "simple-tile-scale-transformer"; 
        
           struct view_node_t::scale_transformer_t : public wf::view_2D 
        
           { 
        
               wf::geometry_t box; 
        
               scale_transformer_t(wayfire_view view, wf::geometry_t box) : 
        
                   wf::view_2D(view) 
        
               { 
        
                   set_box(box); 
        
               } 
        
               void set_box(wf::geometry_t box) 
        
               { 
        
                   assert(box.width > 0 && box.height > 0); 
        
                   this->view->damage(); 
        
                   auto current = this->view->get_wm_geometry(); 
        
                   if ((current.width <= 0) || (current.height <= 0)) 
        
                   { 
        
                       /* view possibly unmapped?? */ 
        
                       return; 
        
                   } 
        
                   double scale_horiz = 1.0 * box.width / current.width; 
        
                   double scale_vert  = 1.0 * box.height / current.height; 
        
                   /* Position of top-left corner after scaling */ 
        
                   double scaled_x = current.x + (current.width / 2.0 * (1 - scale_horiz)); 
        
                   double scaled_y = current.y + (current.height / 2.0 * (1 - scale_vert)); 
        
                   this->scale_x = scale_horiz; 
        
                   this->scale_y = scale_vert; 
        
                   this->translation_x = box.x - scaled_x; 
        
                   this->translation_y = box.y - scaled_y; 
        
               } 
        
           };

Is this workaround still the best way to get around this issue? Is there maybe some way that a plugin can cause a commit manually so that the geometries are in sync?

The plugin is over here: https://github.com/Javyre/swayfire