You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pretty silly issue. Because loop devices -- which ARE block devices -- end in a digit (e.g. /dev/loop0), this line prevents the program from writing to them because WoeUSB assumes the /dev/sdX naming convention for removable drives, and /dev/sdXN (where N is a number) for partitions. The same goes for nvme drives, which have a naming convention that that will make them end in a digit.
A more robust method of checking whether a file is a partition or a disk needs to be implemented to solve this. I'll look into this later. Just mentioning it here for documentation, in case i abandon this for whatever reason.
The text was updated successfully, but these errors were encountered:
The code progresses further by removing the check, but it gets worse: partition 'detection' is also done by concatenation. This means that, for example, the partition naming schemes for loop0p1 and nvme0n1p1 break as well.
Pretty silly issue. Because loop devices -- which ARE block devices -- end in a digit (e.g.
/dev/loop0
), this line prevents the program from writing to them because WoeUSB assumes the/dev/sdX
naming convention for removable drives, and/dev/sdXN
(whereN
is a number) for partitions. The same goes for nvme drives, which have a naming convention that that will make them end in a digit.WoeUSB-ng/WoeUSB/utils.py
Line 95 in 18e8918
A more robust method of checking whether a file is a partition or a disk needs to be implemented to solve this. I'll look into this later. Just mentioning it here for documentation, in case i abandon this for whatever reason.
The text was updated successfully, but these errors were encountered: